Update success messages

Author: blacksmith-welder

staff-features/accessions/accession_create.feature

@@ -5,7 +5,7 @@ Feature: Accession Create
     Given the user is on the New Accession page
     When the user fills in Identifier
     And the user clicks on 'Save'
-    Then the message "Accession created" is displayed
+    Then the 'Accession created' message is displayed
   Scenario: Accession is not created
     Given the user is on the New Accession page
     When the user clicks on 'Save'

staff-features/accessions/accession_delete.feature

@@ -7,8 +7,8 @@ Feature: Accession Delete
     When the user clicks on the checkbox of the accession
     And the user clicks on 'Delete'
     And the user clicks on 'Delete Records'
-    And the message 'Records deleted' is displayed
-    And the message 'No records found' is displayed
+    And the 'Records deleted' message is displayed
+    And the 'No records found' message is displayed
   Scenario: Accession is deleted from the view page
     Given an accession has been created
     And the user is on the accession details page

staff-features/accessions/step_definitions/accession_create.rb

@@ -7,10 +7,6 @@
   click_on 'Accession'
 end
 
-When 'the user fills in Identifier' do
-  fill_in 'Identifier', with: @uuid
-end
-
 Then('a new accession is created') do
   expect(find('h2').text).to eq "Accession #{@uuid} Accession"
   expect(find('.alert.alert-success.with-hide-alert').text).to eq 'Accession created'

staff-features/digital-objects/digital_object_create.feature

@@ -3,10 +3,10 @@ Feature: Create Digital Object
     Given the user is logged in as an administrator
   Scenario: Digital Object is created
     Given the user is on the New Digital Object page
-    When the user fills in Title with a unique id
-    And the user fills in Identifier with a unique id
+    When the user fills in 'Title' with 'Alabama: Mobile: Government Street [Cochran photos]'
+    And the user fills in Identifier
     And the user clicks on 'Save'
-    Then the digital object is created
+    Then the Digital Object created success message is displayed
   Scenario: Digital Object is not created because required fields are missing
     Given the user is on the New Digital Object page
     When the user clicks on 'Save'

staff-features/digital-objects/digital_object_create.rb

@@ -10,15 +10,8 @@
   fill_in 'Title', with: "Digital Object Title #{@uuid}"
 end
 
-When('the user fills in Identifier with a unique id') do
-  fill_in 'Identifier', with: @uuid
-end
-
-Then('the digital object is created') do
-  expect(find('h2').text).to eq "Digital Object Title #{@uuid} Digital Object"
-  expect(find('.alert.alert-success.with-hide-alert').text).to eq "Digital Object Digital Object Title #{@uuid} Created"
-
-  expect_record_to_be_in_search_results(@uuid)
+Then('the Digital Object created success message is displayed') do
+  expect(find('.alert.alert-success.with-hide-alert').text).to match /^Digital Object.*Created$/
 end
 
 Then ('the digital object is not created') do

staff-features/repositories/repository_create.feature

@@ -7,7 +7,7 @@ Feature: Create repository
     And the user fills in the Repository Short Name
     And the user fills in the Repository Name
     And the user clicks on 'Save'
-    Then the message 'Repository Created' is displayed
+    Then the 'Repository Created' message is displayed
     And the repository is created
   Scenario: Repository is not created from a view-only user
     Given the user is logged in as a view-only user

staff-features/shared/step_definitions.rb

@@ -44,8 +44,8 @@
   click_on_string string
 end
 
-When 'the user fills in {string} with {string}' do |label, value|
-  fill_in label, with: value
+When 'the user fills in Identifier' do
+  fill_in 'Identifier', with: @uuid
 end
 
 When 'the user fills in {string} with {string}' do |label, value|
@@ -56,7 +56,7 @@
   select option, from: label
 end
 
-Then 'the message {string} is displayed' do |string|
+Then 'the {string} message is displayed' do |string|
   expect(page).to have_text string
 end
 

staff-features/users/user_create.feature

@@ -9,7 +9,7 @@ Feature: Create User
     And the user fills in the Password
     And the user fills in the Confirm password
     And the user clicks on 'Create Account'
-    Then the message "User Created" is displayed
+    Then the 'User Created' message is displayed
     And the new user should appear in the search results
   Scenario: User is not created because required fields are missing
     Given the user is on the Manage Users page