Fix rubocop offenses

Author: blacksmith-welder

helpers/helpers.rb

@@ -61,9 +61,7 @@ def login_archivist
 
   begin
     element = find('.alert.alert-danger.with-hide-alert')
-    if element.text == 'Login attempt failed'
-      raise "Login failed for user: archivist-user-#{uuid}"
-    end
+    raise "Login failed for user: archivist-user-#{uuid}" if element.text == 'Login attempt failed'
   rescue Capybara::ElementNotFound
     # Pass on successful login
   end

staff_features/repositories/repository_create.rb

@@ -11,10 +11,10 @@
 
   rows = all('#tabledSearchResults tbody tr')
 
-  expect(rows.length > 0).to eq true
+  expect(rows.length.positive?).to eq true
 
   within rows[0] do
-    click_on "View"
+    click_on 'View'
   end
 
   respository_id = current_url.split('/').pop