Calculate extent

Author: blacksmith-welder

.rubocop.yml

@@ -9,12 +9,18 @@ Metrics/AbcSize:
 Metrics/MethodLength:
   Max: 50
 
+Metrics/BlockLength:
+  Max: 90
+
 Layout/LineLength:
   Max: 180
 
 Layout/ElseAlignment:
   Enabled: false
 
+Layout/LineLength:
+  Max: 174
+
 Style/ConditionalAssignment:
   Enabled: false
 

helpers/helpers.rb

@@ -123,6 +123,39 @@ def ensure_test_agent_exists
   end
 end
 
+def ensure_test_subject_exists
+  visit STAFF_URL
+
+  fill_in 'global-search-box', with: 'test_subject'
+  find('#global-search-button').click
+
+  begin
+    find 'tr', text: 'test_subject'
+  rescue Capybara::ElementNotFound
+    visit "#{STAFF_URL}/subjects/new"
+    select 'Art & Architecture Thesaurus', from: 'subject_source_'
+    fill_in 'subject_terms__0__term_', with: 'test_subject_term'
+    select 'Cultural context', from: 'subject_terms__0__term_type_'
+    click_on 'Save'
+  end
+end
+
+def ensure_test_classification_exists
+  visit STAFF_URL
+
+  fill_in 'global-search-box', with: 'test_classification'
+  find('#global-search-button').click
+
+  begin
+    find 'tr', text: 'test_classification'
+  rescue Capybara::ElementNotFound
+    visit "#{STAFF_URL}/classifications/new"
+    fill_in 'classification_identifier_', with: 'test_classification'
+    fill_in 'classification_title_', with: 'test_classification'
+    click_on 'Save'
+  end
+end
+
 def find_user_table_row_in_manage_user_access_page(username)
   loop do
     begin

helpers/original_values.rb

@@ -1,3 +1,4 @@
 # frozen_string_literal: true
 
 ORIGINAL_ACCESSION_DATE = '2000-01-01'
+ORIGINAL_ACCESSION_RIGHTS_STATEMENT_START_DATE = '2000-01-01'

staff_features/accessions/accession_calculate_extent.feature

@@ -1,15 +1,18 @@
-Feature: Calculate extent of an accession
+Feature: Calculate Extent of an accession
   Background:
    Given an administrator user is logged in
      And an Accession has been created
      And the Accession is opened in edit mode
   Scenario: Extent sub record is added to the Accession
-    When the user clicks on 'More' button on the toolbar
-     And the user selects 'Calculate Extent'
-     And the user fills in 'Portion'
-     And the user fills in 'Number'
-     And the user fills in 'Type'
-     And the user clicks on 'Create Extent'
+    When the user clicks on 'More'
+     And the user clicks on 'Calculate Extent'
+     And the user selects 'Whole' from 'Portion' in the modal
+     And the user fills in 'Number' with '123456789' in the modal
+     And the user selects 'Cassettes' from 'Type' in the modal
+     And the user clicks on 'Create Extent' in the modal
      And the user clicks on 'Save'
-    Then a new Extent sub-record should be added to the accession record
-     And the 'Accession' updated message is displayed
+    Then the 'Accession' updated message is displayed
+     And a new Extent is added to the Accession with the following values
+      | Portion      | Whole           |
+      | Number       | 123456789       |
+      | Type         | Cassettes       |

staff_features/accessions/accession_event_create.feature

@@ -13,7 +13,7 @@ Feature: Accession Event Create
       And the user fills in 'Begin' with '2020-01-01' in the 'Event Date/Time' form
       And the user links an Agent
       And the user clicks on 'Save'
-     Then the 'Event Created' message is displayed
+     Then the 'Event' created message is displayed
   Scenario: Accession Event is not created due to missing required fields
     Given the New Event page is open for an Accession
      When the user selects 'Single' from 'Type' in the 'Event Date/Time' form

staff_features/accessions/step_definitions/accession_edit.rb

@@ -122,11 +122,11 @@
 end
 
 When 'User A changes the {string} field' do |field|
-  fill_in field, with: SecureRandom.uuid
+  fill_in field, with: SecureRandom.uuid, match: :first
 end
 
 When 'User B changes the {string} field' do |field|
-  @user_b_session.fill_in field, with: SecureRandom.uuid
+  @user_b_session.fill_in field, with: SecureRandom.uuid, match: :first
 end
 
 When 'User B clicks on {string}' do |string|

staff_features/accessions/step_definitions/accession_shared.rb

@@ -1,5 +1,78 @@
 # frozen_string_literal: true
 
+Given 'an Accession has been created' do
+  visit "#{STAFF_URL}/accessions/new"
+
+  fill_in 'accession_id_0_', with: "Accession #{@uuid}"
+  fill_in 'Title', with: "Accession Title #{@uuid}"
+  fill_in 'accession_accession_date_', with: ORIGINAL_ACCESSION_DATE
+  check 'Publish?'
+
+  fill_in 'accession_content_description_', with: "Content Description #{@uuid}"
+  fill_in 'accession_condition_description_', with: "Condition Description #{@uuid}"
+  fill_in 'accession_disposition_', with: "Disposition #{@uuid}"
+  fill_in 'accession_inventory_', with: "Inventory #{@uuid}"
+  fill_in 'accession_provenance_', with: "Provenance #{@uuid}"
+  fill_in 'accession_retention_rule_', with: "Retention Rule #{@uuid}"
+  fill_in 'accession_general_note_', with: "General Note #{@uuid}"
+  select 'Deposit', from: 'accession_acquisition_type_'
+  select 'Collection', from: 'accession_resource_type_'
+
+  fill_in 'accession_language_', with: 'english'
+  dropdown_items = all('.typeahead.typeahead-long.dropdown-menu')
+  dropdown_items.first.click
+  fill_in 'accession_script_', with: 'adlam'
+  dropdown_items = all('.typeahead.typeahead-long.dropdown-menu')
+  dropdown_items.first.click
+  find('#accession_restrictions_apply_').check
+  find('#accession_access_restrictions_').check
+  fill_in 'accession_access_restrictions_note_', with: "Access Restrictions Note #{@uuid}"
+  find('#accession_use_restrictions_').check
+  fill_in 'accession_use_restrictions_note_', with: "Use Restrictions Note #{@uuid}"
+
+  click_on 'Add Language'
+  fill_in 'Language', with: 'English'
+  dropdown_items = all('.typeahead.typeahead-long.dropdown-menu')
+  dropdown_items.first.click
+  fill_in 'Script', with: 'adlam'
+  dropdown_items = all('.typeahead.typeahead-long.dropdown-menu')
+  dropdown_items.first.click
+
+  click_on 'Add Date'
+  select 'Single', from: 'accession_dates__0__date_type_'
+  fill_in 'accession_dates__0__begin_', with: ORIGINAL_ACCESSION_DATE
+
+  click_on 'Add Extent'
+  fill_in 'Number', with: @uuid
+  select 'Cassettes', from: 'accession_extents__0__extent_type_'
+  @accession_number_of_extents = 1
+
+  click_on 'Add Agent Link'
+  select 'Creator', from: 'accession_linked_agents__0__role_'
+  fill_in 'accession_linked_agents__0__title_', with: "Accession #{@uuid} Agent Title"
+  fill_in 'accession_linked_agents__0__relator_', with: 'annotator'
+  dropdown_items = all('.typeahead.typeahead-long.dropdown-menu')
+  dropdown_items.first.click
+  fill_in 'token-input-accession_linked_agents__0__ref_', with: 'test_agent'
+  dropdown_items = all('li.token-input-dropdown-item2')
+  dropdown_items.first.click
+
+  click_on 'Add Subject'
+  fill_in 'token-input-accession_subjects__0__ref_', with: 'test_subject'
+  dropdown_items = all('li.token-input-dropdown-item2')
+  dropdown_items.first.click
+
+  click_on 'Add Rights Statement'
+  select 'Copyright', from: 'accession_rights_statements__0__rights_type_'
+  fill_in 'accession_rights_statements__0__jurisdiction_', with: 'andorra'
+  dropdown_items = all('.typeahead.typeahead-long.dropdown-menu')
+  dropdown_items.first.click
+  fill_in 'accession_rights_statements__0__start_date_', with: ORIGINAL_ACCESSION_RIGHTS_STATEMENT_START_DATE
+
+  click_on 'Save'
+  expect(page).to have_text "Accession Accession Title #{@uuid} created"
+end
+
 Given 'the Accession is opened in edit mode' do
   visit "#{STAFF_URL}/accessions"
 
@@ -20,3 +93,16 @@
 
   click_on 'Edit'
 end
+
+Then 'a new Extent is added to the Accession with the following values' do |form_values_table|
+  extents = all('#accession_extents_ .subrecord-form-list li')
+
+  expect(extents.length).to eq @accession_number_of_extents + 1
+
+  created_extend = extents.last
+
+  form_values_hash = form_values_table.rows_hash
+  form_values_hash.each do |field, value|
+    expect(created_extend.find_field(field).value).to eq value.downcase.gsub(' ', '_')
+  end
+end

staff_features/accessions/step_definitions/accessions_search.rb

@@ -1,9 +1,5 @@
 # frozen_string_literal: true
 
-Given 'an Accession has been created' do
-  create_accession(@uuid)
-end
-
 Then 'the Accession is in the search results' do
   expect(page).to have_css('tr', text: @uuid)
 end

staff_features/shared/step_definitions.rb

@@ -10,6 +10,8 @@
   ensure_test_repository_exists
   ensure_test_user_exists
   ensure_test_agent_exists
+  ensure_test_subject_exists
+  ensure_test_classification_exists
 end
 
 Given 'an archivist user is logged in' do
@@ -20,6 +22,12 @@
   click_on_string string
 end
 
+When 'the user clicks on {string} in the modal' do |string|
+  within '.modal-content' do
+    click_on_string string
+  end
+end
+
 When 'the user clicks on {string} in the dropdown menu' do |string|
   within '.dropdown-menu' do |dropdown_menu|
     elements = dropdown_menu.all(:xpath, "//*[contains(text(), '#{string}')]")
@@ -42,15 +50,21 @@
 When 'the user fills in {string}' do |label|
   @uuid = SecureRandom.uuid if @uuid.nil?
 
-  fill_in label, with: @uuid
+  fill_in label, with: @uuid, match: :first
 end
 
 When 'the user clears the {string} field' do |label|
-  fill_in label, with: ''
+  fill_in label, with: '', match: :first
 end
 
 When 'the user fills in {string} with {string}' do |label, value|
-  fill_in label, with: value
+  fill_in label, with: value, match: :first
+end
+
+When 'the user fills in {string} with {string} in the modal' do |label, value|
+  within '.modal-content' do
+    fill_in label, with: value, match: :first
+  end
 end
 
 When 'the user fills in {string} with {string} in the {string} form' do |label, value, form_title|
@@ -64,7 +78,13 @@
 end
 
 When 'the user selects {string} from {string}' do |option, label|
-  select option, from: label
+  select option, from: label, match: :first
+end
+
+When 'the user selects {string} from {string} in the modal' do |option, label|
+  within '.modal-content' do
+    select option, from: label
+  end
 end
 
 When 'the user selects {string} from {string} in the {string} form' do |option, label, form_title|
@@ -78,15 +98,15 @@
 end
 
 When 'the user checks {string}' do |label|
-  check label
+  check label, match: :first
 end
 
 When 'the user changes the {string} field to {string}' do |field, value|
-  fill_in field, with: value
+  fill_in field, with: value, match: :first
 end
 
 When 'the user changes the {string} field' do |field|
-  fill_in field, with: SecureRandom.uuid
+  fill_in field, with: SecureRandom.uuid, match: :first
 end
 
 Then('the {string} created message is displayed') do |string|