Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use nullable option in project templates #880

Merged
merged 3 commits into from
May 30, 2024
Merged

chore: use nullable option in project templates #880

merged 3 commits into from
May 30, 2024

Conversation

stijnmoreels
Copy link
Member

Use the <nullable>true</nullable> option in the projects, and fixes any possible null assignment.

Closes #865

@stijnmoreels stijnmoreels requested a review from fgheysels as a code owner May 28, 2024 05:17
@netlify Netlify
Copy link

netlify bot commented May 28, 2024 •
edited
Loading

✅ Deploy Preview for arcus-templates canceled.

Name Link
🔨 Latest commit ea29414
🔍 Latest deploy log https://app.netlify.com/sites/arcus-templates/deploys/66582a555505070008a70723

fgheysels
fgheysels approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@fgheysels fgheysels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !
I like this stricter approach for nullable types

@stijnmoreels stijnmoreels merged commit 6965c7b into arcus-azure:main May 30, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgheysels fgheysels fgheysels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the definition of the ApiHealthReportEntry class
2 participants
@stijnmoreels @fgheysels