From 9960172ba340a4f154862cd566a3de8e8f43e6bb Mon Sep 17 00:00:00 2001
From: stijnmoreels <9039753+stijnmoreels@users.noreply.github.com>
Date: Tue, 25 Jun 2024 09:52:17 +0200
Subject: [PATCH] feat: add async overload for async disposable

---
 src/Arcus.Testing.Core/AsyncDisposable.cs | 23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

diff --git a/src/Arcus.Testing.Core/AsyncDisposable.cs b/src/Arcus.Testing.Core/AsyncDisposable.cs
index fce5b99b..a7d6aa2a 100644
--- a/src/Arcus.Testing.Core/AsyncDisposable.cs
+++ b/src/Arcus.Testing.Core/AsyncDisposable.cs
@@ -18,6 +18,8 @@ private AsyncDisposable(Func<ValueTask> disposeAsync)
         /// <summary>
         /// Creates an <see cref="AsyncDisposable"/> instance based on an existing synchronous <paramref name="disposable"/>.
         /// </summary>
+        /// <param name="disposable">The synchronous disposable to create as an instance.</param>
+        /// <exception cref="ArgumentNullException">Thrown when the <paramref name="disposable"/> is <c>null</c>.</exception>
         public static AsyncDisposable Create(IDisposable disposable)
         {
             if (disposable is null)
@@ -31,6 +33,8 @@ public static AsyncDisposable Create(IDisposable disposable)
         /// <summary>
         /// Creates an <see cref="AsyncDisposable"/> instance based on an existing synchronous <paramref name="dispose"/> operation.
         /// </summary>
+        /// <param name="dispose">The synchronous operation to create as an instance.</param>
+        /// <exception cref="ArgumentNullException">Thrown when the <paramref name="dispose"/> is <c>null</c>.</exception>
         public static AsyncDisposable Create(Action dispose)
         {
             if (dispose is null)
@@ -38,13 +42,28 @@ public static AsyncDisposable Create(Action dispose)
                 throw new ArgumentNullException(nameof(dispose));
             }
 
-            return new AsyncDisposable(() =>
+            return Create(() =>
             {
                 dispose();
-                return ValueTask.CompletedTask;
+                return Task.CompletedTask;
             });
         }
 
+        /// <summary>
+        /// Creates an <see cref="AsyncDisposable"/> instance based on an existing asynchronous <paramref name="disposeAsync"/> operation.
+        /// </summary>
+        /// <param name="disposeAsync">The asynchronous operation to create as an instance.</param>
+        /// <exception cref="ArgumentNullException">Thrown when the <paramref name="disposeAsync"/> is <c>null</c>.</exception>
+        public static AsyncDisposable Create(Func<Task> disposeAsync)
+        {
+            if (disposeAsync is null)
+            {
+                throw new ArgumentNullException(nameof(disposeAsync));
+            }
+
+            return new AsyncDisposable(async () => await disposeAsync());
+        }
+
         /// <summary>
         /// Performs application-defined tasks associated with freeing, releasing, or resetting unmanaged resources asynchronously.
         /// </summary>