Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain required role-permissions #220

Merged

Conversation

stijnmoreels
Copy link
Member

@stijnmoreels stijnmoreels commented Nov 4, 2024

Add the necessary changes in the feature documentation to explain the required role permissions in certain scenarios, plus make sure that we always fail on any of the (even) rudimentairy interactions so that any of these missing permissions gets flagged immediately and we never(!) have false positives.

Closes #217
Closes #218

@stijnmoreels stijnmoreels requested a review from a team as a code owner November 4, 2024 09:53
Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for arcus-testing ready!

Name Link
🔨 Latest commit ca2bd20
🔍 Latest deploy log https://app.netlify.com/sites/arcus-testing/deploys/673305640c008900081673bb
😎 Deploy Preview https://deploy-preview-220--arcus-testing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@arcus-automation
Copy link
Collaborator

arcus-automation commented Nov 4, 2024

🧪 Code coverage summary

Metric Value
Line coverage 🟢 91.4%
Branch coverage 🟢 80.8%

Great job! 😎 Your code coverage is higher than my caffeine levels! ☕

@stijnmoreels stijnmoreels merged commit 399f8ab into arcus-azure:main Nov 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants