Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision with IResult from minimal apis in .Net 6 #85

Open
franklores opened this issue May 4, 2022 · 4 comments
Open

Collision with IResult from minimal apis in .Net 6 #85

franklores opened this issue May 4, 2022 · 4 comments

Comments

@franklores
Copy link

Are there any plans to rename or update to avoid collision with the new IResult interface in .Net 6?

@ardalis
Copy link
Owner

ardalis commented May 4, 2022

There weren't but now that you mention it maybe there should be. I guess imitation is the sincerest form of flattery. It made sense to move away from ActionResult since the new APIs don't use controller actions (or controllers). But IResult is pretty generic for an api result or endpoint result...

Anyway, any suggestions?

@franklores
Copy link
Author

I wish they had used IEndpointResult as the IActionResult is still available, it leaves us with a conundrum... IRequestResult?

@franklores
Copy link
Author

@ardalis I have submitted a pull request for your consideration.

@ardalis
Copy link
Owner

ardalis commented May 16, 2024

Looks like you closed your PR #86.

I'm still looking at updating the namespace as discussed in #93. Would that address this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants