Skip to content

Commit e83c771

Browse files
authored
Merge pull request #1 from hmueller01/minor_output_fixes
Output and string fixes
2 parents 085afdb + f80bbba commit e83c771

File tree

3 files changed

+19
-15
lines changed

3 files changed

+19
-15
lines changed

.gitignore

+1
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,4 @@
3232
*.app
3333

3434
.vscode/
35+
.DS_Store

src/ESP_WiFiManager_Lite.h

+14-11
Original file line numberDiff line numberDiff line change
@@ -1470,11 +1470,16 @@ class ESP_WiFiManager_Lite
14701470

14711471
void displayConfigData(const ESP_WM_LITE_Configuration& configData)
14721472
{
1473-
ESP_WML_LOGERROR5(F("Hdr="), configData.header, F(",SSID="), configData.WiFi_Creds[0].wifi_ssid,
1474-
F(",PW="), configData.WiFi_Creds[0].wifi_pw);
1475-
ESP_WML_LOGERROR3(F("SSID1="), configData.WiFi_Creds[1].wifi_ssid, F(",PW1="), configData.WiFi_Creds[1].wifi_pw);
1473+
ESP_WML_LOGERROR1(F("Hdr="), configData.header);
1474+
ESP_WML_LOGERROR3(F("SSID0="), configData.WiFi_Creds[0].wifi_ssid, F(",PW0="), configData.WiFi_Creds[0].wifi_pw);
1475+
ESP_WML_LOGERROR3(F("SSID1="), configData.WiFi_Creds[1].wifi_ssid, F(",PW1="), configData.WiFi_Creds[1].wifi_pw);
1476+
1477+
#if USING_BOARD_NAME
1478+
14761479
ESP_WML_LOGERROR1(F("BName="), configData.board_name);
14771480

1481+
#endif
1482+
14781483
#if USE_DYNAMIC_PARAMETERS
14791484

14801485
for (uint16_t i = 0; i < NUM_MENU_ITEMS; i++)
@@ -2174,10 +2179,6 @@ class ESP_WiFiManager_Lite
21742179
// If SSID, PW ="blank" or NULL, stay in config mode forever until having config Data.
21752180
return false;
21762181
}
2177-
else
2178-
{
2179-
displayConfigData(ESP_WM_LITE_config);
2180-
}
21812182

21822183
return true;
21832184
}
@@ -2663,6 +2664,7 @@ class ESP_WiFiManager_Lite
26632664
void createHTML(String& root_html_template)
26642665
{
26652666
String pitem;
2667+
pitem.reserve(600);
26662668

26672669
root_html_template = FPSTR(ESP_WM_LITE_HTML_HEAD_START);
26682670

@@ -2706,7 +2708,7 @@ class ESP_WiFiManager_Lite
27062708
if (ListOfSSIDs == "") // No SSID found or none was good enough
27072709
ListOfSSIDs = String(FPSTR(ESP_WM_LITE_OPTION_START)) + String(FPSTR(ESP_WM_LITE_NO_NETWORKS_FOUND)) + String(FPSTR(ESP_WM_LITE_OPTION_END));
27082710

2709-
pitem = String(FPSTR(ESP_WM_LITE_HTML_HEAD_END));
2711+
pitem = FPSTR(ESP_WM_LITE_HTML_HEAD_END);
27102712

27112713
#if MANUAL_SSID_INPUT_ALLOWED
27122714
pitem.replace("[[input_id]]", "<input id='id' list='SSIDs'>" + String(FPSTR(ESP_WM_LITE_DATALIST_START)) + "'SSIDs'>" +
@@ -2724,7 +2726,7 @@ class ESP_WiFiManager_Lite
27242726

27252727
#else
27262728

2727-
pitem = String(FPSTR(ESP_WM_LITE_HTML_HEAD_END));
2729+
pitem = FPSTR(ESP_WM_LITE_HTML_HEAD_END);
27282730
pitem.replace("[[input_id]]", FPSTR(ESP_WM_LITE_HTML_INPUT_ID));
27292731
pitem.replace("[[input_id1]]", FPSTR(ESP_WM_LITE_HTML_INPUT_ID1));
27302732
root_html_template += pitem + FPSTR(ESP_WM_LITE_FLDSET_START);
@@ -2735,7 +2737,7 @@ class ESP_WiFiManager_Lite
27352737

27362738
for (uint16_t i = 0; i < NUM_MENU_ITEMS; i++)
27372739
{
2738-
pitem = String(FPSTR(ESP_WM_LITE_HTML_PARAM));
2740+
pitem = FPSTR(ESP_WM_LITE_HTML_PARAM);
27392741

27402742
pitem.replace("{b}", myMenuItems[i].displayName);
27412743
pitem.replace("{v}", myMenuItems[i].id);
@@ -2752,7 +2754,7 @@ class ESP_WiFiManager_Lite
27522754

27532755
for (uint16_t i = 0; i < NUM_MENU_ITEMS; i++)
27542756
{
2755-
pitem = String(FPSTR(ESP_WM_LITE_HTML_SCRIPT_ITEM));
2757+
pitem = FPSTR(ESP_WM_LITE_HTML_SCRIPT_ITEM);
27562758

27572759
pitem.replace("{d}", myMenuItems[i].id);
27582760

@@ -2804,6 +2806,7 @@ class ESP_WiFiManager_Lite
28042806
//////
28052807

28062808
String result;
2809+
result.reserve(3072);
28072810
createHTML(result);
28082811

28092812
//ESP_WML_LOGDEBUG1(F("h:Repl:"), result);

src/ESP_WiFiManager_Lite_Debug.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@
3636
#endif
3737

3838
// Change _ESP_WM_LITE_LOGLEVEL_ to set tracing and logging verbosity
39-
// 0: DISABLED: no logging
39+
// 0: DISABLED: no logging (default)
4040
// 1: ERROR: errors
4141
// 2: WARN: errors and warnings
42-
// 3: INFO: errors, warnings and informational (default)
42+
// 3: INFO: errors, warnings and informational
4343
// 4: DEBUG: errors, warnings, informational and debug
4444

4545
#ifndef _ESP_WM_LITE_LOGLEVEL_
@@ -77,8 +77,8 @@ const char ESP_WML_MARK[] = "[WML] ";
7777
#define ESP_WML_LOGINFO0(x) if(_ESP_WM_LITE_LOGLEVEL_>2) { ESP_WML_PRINT(x); }
7878
#define ESP_WML_LOGINFO(x) if(_ESP_WM_LITE_LOGLEVEL_>2) { ESP_WML_PRINT_MARK; ESP_WML_PRINTLN(x); }
7979
#define ESP_WML_LOGINFO1(x,y) if(_ESP_WM_LITE_LOGLEVEL_>2) { ESP_WML_PRINT_MARK; ESP_WML_PRINT(x); ESP_WML_PRINTLN(y); }
80-
#define ESP_WML_LOGINFO2(x,y,z) if(_ESP_WM_LITE_LOGLEVEL_>3) { ESP_WML_PRINT_MARK; ESP_WML_PRINT(x); ESP_WML_PRINT(y); ESP_WML_PRINTLN(z); }
81-
#define ESP_WML_LOGINFO3(x,y,z,w) if(_ESP_WM_LITE_LOGLEVEL_>3) { ESP_WML_PRINT_MARK; ESP_WML_PRINT(x); ESP_WML_PRINT(y); ESP_WML_PRINT(z); ESP_WML_PRINTLN(w); }
80+
#define ESP_WML_LOGINFO2(x,y,z) if(_ESP_WM_LITE_LOGLEVEL_>2) { ESP_WML_PRINT_MARK; ESP_WML_PRINT(x); ESP_WML_PRINT(y); ESP_WML_PRINTLN(z); }
81+
#define ESP_WML_LOGINFO3(x,y,z,w) if(_ESP_WM_LITE_LOGLEVEL_>2) { ESP_WML_PRINT_MARK; ESP_WML_PRINT(x); ESP_WML_PRINT(y); ESP_WML_PRINT(z); ESP_WML_PRINTLN(w); }
8282
#define ESP_WML_LOGINFO5(x,y,z,w,xx,yy) if(_ESP_WM_LITE_LOGLEVEL_>2) { ESP_WML_PRINT_MARK; ESP_WML_PRINT(x); ESP_WML_PRINT(y); ESP_WML_PRINT(z); ESP_WML_PRINT(w); ESP_WML_PRINT(xx); ESP_WML_PRINTLN(yy); }
8383

8484
///////////////////////////////////////////

0 commit comments

Comments
 (0)