Skip to content

Commit 44888a9

Browse files
committed
Revert "Fix regression: report size delta size on PR. (#83)"
This reverts commit a27655e.
1 parent a27655e commit 44888a9

File tree

3 files changed

+27
-24
lines changed

3 files changed

+27
-24
lines changed

Diff for: .github/workflows/compile-examples.yml

+2-23
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,8 @@ on:
2020
workflow_dispatch:
2121
repository_dispatch:
2222

23-
env:
24-
# It's convenient to set variables for values used multiple times in the workflow.
25-
SKETCHES_REPORTS_PATH: sketches-reports
26-
2723
jobs:
28-
compile:
24+
build:
2925
name: ${{ matrix.board.fqbn }}
3026
runs-on: ubuntu-latest
3127

@@ -39,6 +35,7 @@ jobs:
3935
UNIVERSAL_SKETCH_PATHS: |
4036
- examples/SHA1
4137
- examples/SHA256
38+
SKETCHES_REPORTS_PATH: sketches-reports
4239

4340
strategy:
4441
fail-fast: false
@@ -98,21 +95,3 @@ jobs:
9895
if-no-files-found: error
9996
path: ${{ env.SKETCHES_REPORTS_PATH }}
10097
name: sketches-report-${{ matrix.board.artifact-name-suffix }}
101-
102-
# When using a matrix to compile for multiple boards, it's necessary to use a separate job for the deltas report
103-
report:
104-
needs: compile # Wait for the compile job to finish to get the data for the report
105-
if: github.event_name == 'pull_request' # Only run the job when the workflow is triggered by a pull request
106-
runs-on: ubuntu-latest
107-
108-
steps:
109-
# This step is needed to get the size data produced by the compile jobs
110-
- name: Download sketches reports artifacts
111-
uses: actions/download-artifact@v4
112-
with:
113-
# All workflow artifacts will be downloaded to this location.
114-
path: ${{ env.SKETCHES_REPORTS_PATH }}
115-
116-
- uses: arduino/report-size-deltas@v1
117-
with:
118-
sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }}

Diff for: .github/workflows/report-size-deltas.yml

+25
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
name: Report Size Deltas
2+
3+
# See: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows
4+
on:
5+
push:
6+
paths:
7+
- ".github/workflows/report-size-deltas.yml"
8+
schedule:
9+
# Run at the minimum interval allowed by GitHub Actions.
10+
# Note: GitHub Actions periodically has outages which result in workflow failures.
11+
# In this event, the workflows will start passing again once the service recovers.
12+
- cron: "*/5 * * * *"
13+
workflow_dispatch:
14+
repository_dispatch:
15+
16+
jobs:
17+
report:
18+
runs-on: ubuntu-latest
19+
20+
steps:
21+
- name: Comment size deltas reports to PRs
22+
uses: arduino/report-size-deltas@v1
23+
with:
24+
# The name of the workflow artifact created by the sketch compilation workflow
25+
sketches-reports-source: sketches-reports

Diff for: .gitignore

-1
This file was deleted.

0 commit comments

Comments
 (0)