Skip to content

Please release version and tag #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rzr opened this issue Jul 11, 2019 · 4 comments
Closed

Please release version and tag #6

rzr opened this issue Jul 11, 2019 · 4 comments
Labels
conclusion: resolved Issue was resolved topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement

Comments

@rzr
Copy link

rzr commented Jul 11, 2019

I am looking a way to to pin my dependencies, would this be possible to have tags in this repo ?

Eventually aligned the arduino sdk ones

@per1234 per1234 added the type: enhancement Proposed improvement label Jul 12, 2019
@thekunalsaini
Copy link

@rzr @per1234 Can you elaborate what you are trying to say?

@rzr
Copy link
Author

rzr commented Mar 20, 2020

having tags in git repo would help because my project uses makefiles to pull libs using git clone.

@MisterAwesome23
Copy link

I tried creating a v1.0.0 release and tag on my fork. You can have a look at it here

I read through a few standard rules and naming conventions before giving it a base numbers. Few resources if someone wants to follow up-

  1. https://semver.org/
  2. https://softwareengineering.stackexchange.com/questions/345006/why-popular-repositories-use-release-version-as-a-release-title-in-github
  3. https://rollout.io/blog/best-practices-when-versioning-a-release/

Now though I've added the release and tag to my fork, it turn out that it can't be included in a pull request and hence I can not create a PR for this. More on this here.

" A pull request does not include tags. A pull request is only a pointer to a thread of commits (a branch) in your repository that you're proposing another repository to merge."

"The best and only method really becomes to ask the maintainer to issue a release for his code by tagging if that's the way they do it but that is to their discretion!"

So, @TrippyLighting or any maintainer for this, kindly look into my release on fork, preferably add appropriate release description and make changes.

@alranel
Copy link

alranel commented Oct 31, 2023

Released! Will be available in the library manager shortly.

@alranel alranel closed this as completed Oct 31, 2023
@per1234 per1234 added topic: infrastructure Related to project infrastructure conclusion: resolved Issue was resolved labels Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

5 participants