Skip to content

Commit 7e0b929

Browse files
authored
Fix: Arduino_Alvik::drive() not working due to function parameter not being used. (#8)
There was an additional bug concerning erroneous unit conversion.
1 parent 1cc083a commit 7e0b929

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/Arduino_Alvik.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -394,12 +394,12 @@ void Arduino_Alvik::get_drive_speed(float & linear, float & angular, const uint8
394394

395395
void Arduino_Alvik::drive(const float linear, const float angular, const uint8_t linear_unit, const uint8_t angular_unit){
396396
if (angular_unit == PERCENTAGE){
397-
converted_angular = (robot_velocity[1]/ROBOT_MAX_DEG_S)*100.0;
397+
converted_angular = (angular/ROBOT_MAX_DEG_S)*100.0;
398398
}
399399
else{
400-
converted_angular = convert_rotational_speed(robot_velocity[1], DEG_S, angular_unit);
401-
}
402-
msg_size = packeter->packetC2F('V', convert_speed(linear, linear_unit, MM_S), angular);
400+
converted_angular = convert_rotational_speed(angular, angular_unit, DEG_S);
401+
}
402+
msg_size = packeter->packetC2F('V', convert_speed(linear, linear_unit, MM_S), converted_angular);
403403
uart->write(packeter->msg, msg_size);
404404
}
405405

0 commit comments

Comments
 (0)