Skip to content

Commit 95de8e7

Browse files
authored
Merge pull request #80 from pennam/esp-defines
Use generic defines ARDUINO_ARCH_ESP8266 and ARDUINO_ARCH_ESP32
2 parents a12ef24 + f476884 commit 95de8e7

File tree

2 files changed

+18
-49
lines changed

2 files changed

+18
-49
lines changed

Diff for: src/Arduino_ConnectionHandler.h

+10-41
Original file line numberDiff line numberDiff line change
@@ -74,38 +74,7 @@
7474
#define BOARD_HAS_LORA
7575
#endif
7676

77-
#if defined(ARDUINO_ESP8266_ESP12) \
78-
|| defined(ESP8266) \
79-
|| defined(ESP8266_ESP01) \
80-
|| defined(ESP8266_ESP13) \
81-
|| defined(ESP8266_GENERIC) \
82-
|| defined(ESP8266_ESPRESSO_LITE_V1) \
83-
|| defined(ESP8266_ESPRESSO_LITE_V2) \
84-
|| defined(ESP8266_PHOENIX_V1) \
85-
|| defined(ESP8266_PHOENIX_V2) \
86-
|| defined(ESP8266_NODEMCU) \
87-
|| defined(MOD_WIFI_ESP8266) \
88-
|| defined(ESP8266_THING) \
89-
|| defined(ESP8266_THING_DEV) \
90-
|| defined(ESP8266_ESP210) \
91-
|| defined(ESP8266_WEMOS_D1MINI) \
92-
|| defined(ESP8266_WEMOS_D1MINIPRO) \
93-
|| defined(ESP8266_WEMOS_D1MINILITE) \
94-
|| defined(ESP8266_WEMOS_D1R1) \
95-
|| defined(ESP8266_ESP12) \
96-
|| defined(WIFINFO) \
97-
|| defined(ESP8266_ARDUINO) \
98-
|| defined(GEN4_IOD) \
99-
|| defined(ESP8266_OAK) \
100-
|| defined(WIFIDUINO_ESP8266) \
101-
|| defined(AMPERKA_WIFI_SLOT) \
102-
|| defined(ESP8266_WIO_LINK) \
103-
|| defined(ESP8266_ESPECTRO_CORE)
104-
105-
#define BOARD_ESP8266
106-
#endif
107-
108-
#if defined(BOARD_ESP8266)
77+
#if defined(ARDUINO_ARCH_ESP8266)
10978
#include <ESP8266WiFi.h>
11079
#include <WiFiUdp.h>
11180

@@ -116,15 +85,15 @@
11685
#define WIFI_FIRMWARE_VERSION_REQUIRED WIFI_FIRMWARE_REQUIRED
11786
#endif
11887

119-
#if defined(ESP32)
120-
#include <WiFi.h>
121-
#include <WiFiUdp.h>
122-
#define BOARD_HAS_WIFI
123-
#define NETWORK_HARDWARE_ERROR WL_NO_SHIELD
124-
#define NETWORK_IDLE_STATUS WL_IDLE_STATUS
125-
#define NETWORK_CONNECTED WL_CONNECTED
126-
#define WIFI_FIRMWARE_VERSION_REQUIRED WIFI_FIRMWARE_REQUIRED
127-
88+
#if defined(ARDUINO_ARCH_ESP32)
89+
#include <WiFi.h>
90+
#include <WiFiUdp.h>
91+
92+
#define BOARD_HAS_WIFI
93+
#define NETWORK_HARDWARE_ERROR WL_NO_SHIELD
94+
#define NETWORK_IDLE_STATUS WL_IDLE_STATUS
95+
#define NETWORK_CONNECTED WL_CONNECTED
96+
#define WIFI_FIRMWARE_VERSION_REQUIRED WIFI_FIRMWARE_REQUIRED
12897
#endif
12998

13099
/******************************************************************************

Diff for: src/Arduino_WiFiConnectionHandler.cpp

+8-8
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ WiFiConnectionHandler::WiFiConnectionHandler(char const * ssid, char const * pas
4141

4242
unsigned long WiFiConnectionHandler::getTime()
4343
{
44-
#if !defined(BOARD_ESP8266) && !defined(ESP32)
44+
#if !defined(ARDUINO_ARCH_ESP8266) && !defined(ARDUINO_ARCH_ESP32)
4545
return WiFi.getTime();
4646
#else
4747
return 0;
@@ -54,7 +54,7 @@ unsigned long WiFiConnectionHandler::getTime()
5454

5555
NetworkConnectionState WiFiConnectionHandler::update_handleInit()
5656
{
57-
#if !defined(BOARD_ESP8266) && !defined(ESP32)
57+
#if !defined(ARDUINO_ARCH_ESP8266) && !defined(ARDUINO_ARCH_ESP32)
5858
#if !defined(__AVR__)
5959
Debug.print(DBG_INFO, F("WiFi.status(): %d"), WiFi.status());
6060
#endif
@@ -87,19 +87,19 @@ NetworkConnectionState WiFiConnectionHandler::update_handleInit()
8787
delay(300);
8888
WiFi.begin(_ssid, _pass);
8989
delay(1000);
90-
#endif /* #if !defined(BOARD_ESP8266) && !defined(ESP32) */
90+
#endif /* #if !defined(ARDUINO_ARCH_ESP8266) && !defined(ARDUINO_ARCH_ESP32) */
9191

9292
return NetworkConnectionState::CONNECTING;
9393
}
9494

9595
NetworkConnectionState WiFiConnectionHandler::update_handleConnecting()
9696
{
97-
#if !defined(BOARD_ESP8266) && !defined(ESP32)
97+
#if !defined(ARDUINO_ARCH_ESP8266) && !defined(ARDUINO_ARCH_ESP32)
9898
if (WiFi.status() != WL_CONNECTED)
9999
{
100100
WiFi.begin(_ssid, _pass);
101101
}
102-
#endif /* ifndef BOARD_ESP8266 */
102+
#endif /* #if !defined(ARDUINO_ARCH_ESP8266) && !defined(ARDUINO_ARCH_ESP32) */
103103

104104
if (WiFi.status() != NETWORK_CONNECTED)
105105
{
@@ -114,7 +114,7 @@ NetworkConnectionState WiFiConnectionHandler::update_handleConnecting()
114114
#if !defined(__AVR__)
115115
Debug.print(DBG_INFO, F("Connected to \"%s\""), _ssid);
116116
#endif
117-
#if defined(BOARD_ESP8266) || defined(ESP32)
117+
#if defined(ARDUINO_ARCH_ESP8266) || defined(ARDUINO_ARCH_ESP32)
118118
configTime(0, 0, "time.arduino.cc", "pool.ntp.org", "time.nist.gov");
119119
#endif
120120
return NetworkConnectionState::CONNECTED;
@@ -149,9 +149,9 @@ NetworkConnectionState WiFiConnectionHandler::update_handleDisconnecting()
149149

150150
NetworkConnectionState WiFiConnectionHandler::update_handleDisconnected()
151151
{
152-
#if !defined(BOARD_ESP8266) && !defined(ESP32)
152+
#if !defined(ARDUINO_ARCH_ESP8266) && !defined(ARDUINO_ARCH_ESP32)
153153
WiFi.end();
154-
#endif /* ifndef BOARD_ESP8266 */
154+
#endif /* #if !defined(ARDUINO_ARCH_ESP8266) && !defined(ARDUINO_ARCH_ESP32) */
155155
if (_keep_alive)
156156
{
157157
return NetworkConnectionState::INIT;

0 commit comments

Comments
 (0)