Skip to content

Commit 79fd218

Browse files
committed
Fix build with esp core greater than 3.0.4
1 parent 5ed0df5 commit 79fd218

File tree

2 files changed

+23
-3
lines changed

2 files changed

+23
-3
lines changed

src/Arduino_ESP32_OTA.cpp

+19-2
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ Arduino_ESP32_OTA::Arduino_ESP32_OTA()
3434
, _http_client(nullptr)
3535
,_ca_cert{amazon_root_ca}
3636
,_ca_cert_bundle{nullptr}
37+
,_ca_cert_bundle_size(0)
3738
,_magic(0)
3839
{
3940

@@ -83,6 +84,14 @@ void Arduino_ESP32_OTA::setCACertBundle (const uint8_t * bundle)
8384
}
8485
}
8586

87+
void Arduino_ESP32_OTA::setCACertBundle (const uint8_t * bundle, size_t size)
88+
{
89+
if(bundle != nullptr && size != 0) {
90+
_ca_cert_bundle = bundle;
91+
_ca_cert_bundle_size = size;
92+
}
93+
}
94+
8695
void Arduino_ESP32_OTA::setMagic(uint32_t magic)
8796
{
8897
_magic = magic;
@@ -114,9 +123,17 @@ int Arduino_ESP32_OTA::startDownload(const char * ota_url)
114123
_client = new WiFiClientSecure();
115124
if (_ca_cert != nullptr) {
116125
static_cast<WiFiClientSecure*>(_client)->setCACert(_ca_cert);
117-
} else if (_ca_cert_bundle != nullptr) {
126+
}
127+
#if (ESP_ARDUINO_VERSION < ESP_ARDUINO_VERSION_VAL(3, 0, 4))
128+
else if (_ca_cert_bundle != nullptr) {
118129
static_cast<WiFiClientSecure*>(_client)->setCACertBundle(_ca_cert_bundle);
119-
} else {
130+
}
131+
#else
132+
else if (_ca_cert_bundle != nullptr && _ca_cert_bundle_size != 0) {
133+
static_cast<WiFiClientSecure*>(_client)->setCACertBundle(_ca_cert_bundle, _ca_cert_bundle_size);
134+
}
135+
#endif
136+
else {
120137
DEBUG_VERBOSE("%s: CA not configured for download client");
121138
}
122139
} else {

src/Arduino_ESP32_OTA.h

+4-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
#include <Arduino_DebugUtils.h>
2626
#include <WiFiClientSecure.h>
27+
#include <WiFi.h>
2728
#include "decompress/utility.h"
2829
#include "decompress/lzss.h"
2930
#include <ArduinoHttpClient.h>
@@ -87,7 +88,8 @@ class Arduino_ESP32_OTA
8788
Arduino_ESP32_OTA::Error begin(uint32_t magic = ARDUINO_ESP32_OTA_MAGIC);
8889
void setMagic(uint32_t magic);
8990
void setCACert(const char *rootCA);
90-
void setCACertBundle(const uint8_t * bundle);
91+
void setCACertBundle(const uint8_t * bundle) __attribute__((deprecated));
92+
void setCACertBundle (const uint8_t * bundle, size_t size);
9193

9294
// blocking version for the download
9395
// returns the size of the downloaded binary
@@ -151,6 +153,7 @@ class Arduino_ESP32_OTA
151153
HttpClient* _http_client;
152154
const char * _ca_cert;
153155
const uint8_t * _ca_cert_bundle;
156+
size_t _ca_cert_bundle_size;
154157
uint32_t _magic;
155158

156159
void clean();

0 commit comments

Comments
 (0)