You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 28, 2024. It is now read-only.
Switch to contributor-friendly approach to size deltas CI report
The CI system makes a report of the change to memory usage of the example sketches that results from the changes made in
a pull request. It does this via a comment on the PR thread. In order to do that, it needs write permissions in the
repository. As a security precaution, workflow runs triggered by a pull request from a fork are not given the necessary
write permissions.
The workflow was added in the early development phase when the repository was still private. In that situation, the
approach of triggering the deltas report from the pull_request event was the best but now the repository is public and
it's important to get reports on pull requests that come from forks. So the approach of using a dedicated
workflow triggered by the schedule event (which does have write permissions) is better.
Copy file name to clipboardExpand all lines: .github/workflows/compile-examples.yml
-21
Original file line number
Diff line number
Diff line change
@@ -53,24 +53,3 @@ jobs:
53
53
if-no-files-found: error
54
54
path: ${{ env.SKETCHES_REPORTS_PATH }}
55
55
name: ${{ env.SKETCHES_REPORTS_ARTIFACT_NAME }}
56
-
57
-
report:
58
-
needs: compile-examples
59
-
# Only run the job when the workflow is triggered by a pull request from this repository (because arduino/report-size-deltas requires write permissions)
0 commit comments