Skip to content
This repository was archived by the owner on Feb 28, 2024. It is now read-only.

I2Cdev is old and has major issues #119

Closed
JojoS62 opened this issue Jan 21, 2024 · 2 comments · Fixed by #120
Closed

I2Cdev is old and has major issues #119

JojoS62 opened this issue Jan 21, 2024 · 2 comments · Fixed by #120
Assignees
@leonardocavagnis
Labels
conclusion: resolved Issue was resolved topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project

Comments

@JojoS62
Copy link

JojoS62 commented Jan 21, 2024 •
edited by per1234
Loading

Arduino_MachineControl/src/utility/ioexpander/I2Cdev.cpp

Lines 285 to 286 in ca7ff9b

Wire.beginTransmission(devAddr);
Wire.requestFrom(devAddr, (uint8_t)min(length - k, BUFFER_LENGTH));

Surrounding Wire.requestFrom() with Wire.beginTransmission(devAddr); / Wire.endTransmission(); is not the correct usage of the Wire lib.

This bug has been fixed in I2Cdev already 2 Years ago in
jrowberg/i2cdevlib@98a3b4e
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: infrastructure Related to project infrastructure labels Jan 21, 2024
@leonardocavagnis leonardocavagnis mentioned this issue Jan 23, 2024
Merged
@leonardocavagnis leonardocavagnis linked a pull request Jan 23, 2024 that will close this issue
Update I2CDev library #120
Merged
@leonardocavagnis
Copy link
Collaborator

Dear @JojoS62,
Thanks! I open the PR #120

Consider that this library will be deprecated soon. Please, switch to the new one (This issue will be fix also in the new).

@JojoS62
Copy link
Author

JojoS62 commented Jan 24, 2024 •
edited
Loading

thanks for your fast response!
And also for pointing to the new lib, I was not aware of this.

@per1234 per1234 added the conclusion: resolved Issue was resolved label Jan 24, 2024
@leonardocavagnis leonardocavagnis mentioned this issue Jan 24, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leonardocavagnis leonardocavagnis

Labels
conclusion: resolved Issue was resolved topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update I2CDev library leonardocavagnis/Arduino_MachineControl
3 participants
@JojoS62 @per1234 @leonardocavagnis