nmasic: limit retries in chip_apply_conf()

benpicco · benpicco · commit 6416928abb8f · 2022-06-15T18:11:42.000+02:00
diff --git a/src/driver/source/nmasic.c b/src/driver/source/nmasic.c
@@ -65,6 +65,7 @@
 sint8 chip_apply_conf(uint32 u32Conf)
 {
 	sint8 ret = M2M_SUCCESS;
+	uint16 retries = TIMEOUT;
 	uint32 val32 = u32Conf;
 	
 #if (defined __ENABLE_PMU__) || (defined CONF_WINC_INT_PMU)
@@ -98,9 +99,9 @@ sint8 chip_apply_conf(uint32 u32Conf)
 		} else {
 			break;
 		}
-	} while(1);
+	} while(--retries);
 
-	return M2M_SUCCESS;
+	return retries ? M2M_SUCCESS : M2M_ERR_TIME_OUT;
 }
 void chip_idle(void)
 {

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,7 @@`
`65`	`65`	`sint8 chip_apply_conf(uint32 u32Conf)`
`66`	`66`	`{`
`67`	`67`	`sint8 ret = M2M_SUCCESS;`
	`68`	`+ uint16 retries = TIMEOUT;`
`68`	`69`	`uint32 val32 = u32Conf;`
`69`	`70`
`70`	`71`	`#if (defined __ENABLE_PMU__) \|\| (defined CONF_WINC_INT_PMU)`
`@@ -98,9 +99,9 @@ sint8 chip_apply_conf(uint32 u32Conf)`
`98`	`99`	`} else {`
`99`	`100`	`break;`
`100`	`101`	`}`
`101`		`- } while(1);`
	`102`	`+ } while(--retries);`
`102`	`103`
`103`		`- return M2M_SUCCESS;`
	`104`	`+ return retries ? M2M_SUCCESS : M2M_ERR_TIME_OUT;`
`104`	`105`	`}`
`105`	`106`	`void chip_idle(void)`
`106`	`107`	`{`