Boards Manager: contributions MAY miss tools, but we missed to consider this case. Fixes #3248

Author: Federico Fissore

Diff for: arduino-core/src/cc/arduino/contributions/packages/ContributedPlatform.java

@@ -93,6 +93,6 @@ public void setParentPackage(ContributedPackage parentPackage) {
 
   @Override
   public String toString() {
-    return getParsedVersion();
+    return getName() + " " + getParsedVersion();
   }
 }

Diff for: arduino-core/src/cc/arduino/contributions/packages/ContributedToolReference.java

@@ -40,6 +40,7 @@ public abstract class ContributedToolReference {
 
   public ContributedTool resolve(Collection<ContributedPackage> packages) {
     for (ContributedPackage pack : packages) {
+      assert pack.getTools() != null;
       for (ContributedTool tool : pack.getTools())
         if (tool.getName().equals(getName()) &&
             tool.getVersion().equals(getVersion()) &&
@@ -54,4 +55,4 @@ public String toString() {
     return "name=" + getName() + " version=" + getVersion() + " packager=" +
         getPackager();
   }
-}
+}

Diff for: arduino-core/src/cc/arduino/contributions/packages/ContributionsIndexer.java

@@ -91,13 +91,20 @@ public void parseIndex() throws Exception {
     }
 
     List<ContributedPackage> packages = index.getPackages();
+    Collection<ContributedPackage> packagesWithTools = Collections2.filter(packages, new Predicate<ContributedPackage>() {
+      @Override
+      public boolean apply(ContributedPackage input) {
+        return input.getTools() != null;
+      }
+    });
+
     for (ContributedPackage pack : packages) {
       for (ContributedPlatform platform : pack.getPlatforms()) {
         // Set a reference to parent packages
         platform.setParentPackage(pack);
 
         // Resolve tools dependencies (works also as a check for file integrity)
-        platform.resolveToolsDependencies(packages);
+        platform.resolveToolsDependencies(packagesWithTools);
       }
     }