GSM: change restart flag default value to false

pennam · pennam · commit 15f028847069 · 2024-11-14T17:09:59.000+01:00
diff --git a/libraries/GSM/src/GSM.cpp b/libraries/GSM/src/GSM.cpp
@@ -59,7 +59,9 @@ int arduino::GSMClass::begin(const char* pin, const char* apn, const char* usern
   digitalWrite(MBED_CONF_GEMALTO_CINTERION_RST, LOW);
 
   /* Reset module if needed */
-  if (restart || isCmuxEnable()) {
+  const bool emergencyReset = restart || isCmuxEnable();
+  DEBUG_INFO("Emergency reset %s", emergencyReset ? "enabled" : "disabled");
+  if (emergencyReset) {
     reset();
   }
 
diff --git a/libraries/GSM/src/GSM.h b/libraries/GSM/src/GSM.h
@@ -86,7 +86,7 @@ class GSMClass : public MbedSocketClass {
    *
    * return: 0 in case of success, negative number in case of failure
    */
-  int begin(const char* pin, const char* apn, const char* username, const char* password, RadioAccessTechnologyType rat = CATNB, uint32_t band = BAND_20, bool restart = true);
+  int begin(const char* pin, const char* apn, const char* username, const char* password, RadioAccessTechnologyType rat = CATNB, uint32_t band = BAND_20, bool restart = false);
 
   /*
    * Disconnect from the network

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,9 @@ int arduino::GSMClass::begin(const char* pin, const char* apn, const char* usern`
`59`	`59`	`digitalWrite(MBED_CONF_GEMALTO_CINTERION_RST, LOW);`
`60`	`60`
`61`	`61`	`/* Reset module if needed */`
`62`		`- if (restart \|\| isCmuxEnable()) {`
	`62`	`+ const bool emergencyReset = restart \|\| isCmuxEnable();`
	`63`	`+ DEBUG_INFO("Emergency reset %s", emergencyReset ? "enabled" : "disabled");`
	`64`	`+ if (emergencyReset) {`
`63`	`65`	`reset();`
`64`	`66`	`}`
`65`	`67`
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ class GSMClass : public MbedSocketClass {`
`86`	`86`	`*`
`87`	`87`	`* return: 0 in case of success, negative number in case of failure`
`88`	`88`	`*/`
`89`		`- int begin(const char* pin, const char* apn, const char* username, const char* password, RadioAccessTechnologyType rat = CATNB, uint32_t band = BAND_20, bool restart = true);`
	`89`	`+ int begin(const char* pin, const char* apn, const char* username, const char* password, RadioAccessTechnologyType rat = CATNB, uint32_t band = BAND_20, bool restart = false);`
`90`	`90`
`91`	`91`	`/*`
`92`	`92`	`* Disconnect from the network`