Skip to content

Commit 45e2945

Browse files
committed
Configure post-install script to only operate when platform installed on Linux machine
The Arduino Boards Manager automatically executes the `post_install.sh` script during installation of the platform on a non-Windows machine. The platform's post-install script is Linux-specific, but no provisions were made in the script code for the fact that it is also executed on macOS machines. Previously, this was fairly innocuous because, although misleading, the message printed to the output during the platform installation was short and cryptic and thus easy for the average macOS user to ignore: ``` Configuring platform. Please run as root ``` Since it is important for Linux users to manually run the script and the previous message did not effectively communicate that, the script was recently modified to print helpful instructions during the Boards Manager installation. The fact that the script is also executed on macOS machines was not considered in that work. This meant that, although an improvement for the Linux user experience was accomplished, the macOS user experience was worsened because those users were then presented with more prominent and detailed inappropriate instructions than the former easy to miss "Please run as root" instruction. For example ``` Configuring platform. You might need to configure permissions for uploading. To do so, run the following command from the terminal: sudo "/Users/per/Library/Arduino15/packages/arduino/hardware/mbed_giga/4.1.5/post_install.sh" ``` The problem is fixed by adjusting the script so that the script simply returns silently if it is invoked on a non-Linux machine. macOS users will now only see the following benign message in the output during the Boards Manager installation: ``` Configuring platform. ``` The POSIX-compliant shell code for determining the operating system the script is running under was derived from the Arduino CLI application's cross-platform installation script, which has withstood the test of time after years of use by a large user base.
1 parent 1399d64 commit 45e2945

File tree

1 file changed

+24
-18
lines changed

1 file changed

+24
-18
lines changed

post_install.sh

+24-18
Original file line numberDiff line numberDiff line change
@@ -12,25 +12,31 @@ SUBSYSTEMS=="usb", ATTRS{idVendor}=="0525", MODE:="0666"
1212
EOF
1313
}
1414

15-
if [ "$EUID" -ne 0 ]; then
16-
if [ -e "${PWD}/post_install.sh" ]; then
17-
echo
18-
echo "You might need to configure permissions for uploading."
19-
echo "To do so, run the following command from the terminal:"
20-
echo "sudo \"${PWD}/post_install.sh\""
21-
echo
22-
else
23-
# Script was executed from another path. It is assumed this will only occur when user is executing script directly.
24-
# So it is not necessary to provide the command line.
25-
echo "Please run as root"
15+
OS="$(uname -s)"
16+
case "$OS" in
17+
Linux*)
18+
if [ "$EUID" -ne 0 ]; then
19+
if [ -e "${PWD}/post_install.sh" ]; then
20+
echo
21+
echo "You might need to configure permissions for uploading."
22+
echo "To do so, run the following command from the terminal:"
23+
echo "sudo \"${PWD}/post_install.sh\""
24+
echo
25+
else
26+
# Script was executed from another path. It is assumed this will only occur when user is executing script directly.
27+
# So it is not necessary to provide the command line.
28+
echo "Please run as root"
29+
fi
30+
31+
exit
2632
fi
2733

28-
exit
29-
fi
34+
arduino_mbed_rules > /etc/udev/rules.d/60-arduino-mbed.rules
3035

31-
arduino_mbed_rules > /etc/udev/rules.d/60-arduino-mbed.rules
36+
# reload udev rules
37+
echo "Reload rules..."
38+
udevadm trigger
39+
udevadm control --reload-rules
3240

33-
# reload udev rules
34-
echo "Reload rules..."
35-
udevadm trigger
36-
udevadm control --reload-rules
41+
;;
42+
esac

0 commit comments

Comments
 (0)