Skip to content

Commit 1c1369d

Browse files
facchinmcmaglie
authored andcommitted
Include hpp and hh files when searching for libraries
Fixes #181 Syncs up with arduino/Arduino#3485 Signed-off-by: Martino Facchin <[email protected]>
1 parent 29e9297 commit 1c1369d

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

Diff for: src/arduino.cc/builder/builder.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ import (
4343
)
4444

4545
var MAIN_FILE_VALID_EXTENSIONS = map[string]bool{".ino": true, ".pde": true}
46-
var ADDITIONAL_FILE_VALID_EXTENSIONS = map[string]bool{".h": true, ".c": true, ".hpp": true, ".cpp": true, ".s": true}
46+
var ADDITIONAL_FILE_VALID_EXTENSIONS = map[string]bool{".h": true, ".c": true, ".hpp": true, ".hh": true, ".cpp": true, ".s": true}
4747
var ADDITIONAL_FILE_VALID_EXTENSIONS_NO_HEADERS = map[string]bool{".c": true, ".cpp": true, ".s": true}
4848

4949
var LIBRARY_MANDATORY_PROPERTIES = []string{constants.LIBRARY_NAME, constants.LIBRARY_VERSION, constants.LIBRARY_AUTHOR, constants.LIBRARY_MAINTAINER}

Diff for: src/arduino.cc/builder/builder_utils/utils.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ func compileFilesWithExtensionWithRecipe(objectFiles []string, sourcePath string
8989
}
9090

9191
func findFilesInFolder(sourcePath string, extension string, recurse bool) ([]string, error) {
92-
files, err := utils.ReadDirFiltered(sourcePath, utils.FilterFilesWithExtension(extension))
92+
files, err := utils.ReadDirFiltered(sourcePath, utils.FilterFilesWithExtensions(extension))
9393
if err != nil {
9494
return nil, i18n.WrapError(err)
9595
}

Diff for: src/arduino.cc/builder/libraries_loader.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ func (s *LibrariesLoader) Run(ctx *types.Context) error {
9191

9292
headerToLibraries := make(map[string][]*types.Library)
9393
for _, library := range libraries {
94-
headers, err := utils.ReadDirFiltered(library.SrcFolder, utils.FilterFilesWithExtension(".h"))
94+
headers, err := utils.ReadDirFiltered(library.SrcFolder, utils.FilterFilesWithExtensions(".h", ".hpp", ".hh"))
9595
if err != nil {
9696
return i18n.WrapError(err)
9797
}

Diff for: src/arduino.cc/builder/utils/utils.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -138,11 +138,11 @@ func FilterDirs(files []os.FileInfo) []os.FileInfo {
138138
return filtered
139139
}
140140

141-
func FilterFilesWithExtension(extension string) filterFiles {
141+
func FilterFilesWithExtensions(extensions ...string) filterFiles {
142142
return func(files []os.FileInfo) []os.FileInfo {
143143
var filtered []os.FileInfo
144144
for _, file := range files {
145-
if !file.IsDir() && filepath.Ext(file.Name()) == extension {
145+
if !file.IsDir() && SliceContains(extensions, filepath.Ext(file.Name())) {
146146
filtered = append(filtered, file)
147147
}
148148
}

0 commit comments

Comments
 (0)