task go:format + upgrade go version in ci workflows

stefanotorneo · stefanotorneo · commit 5a18cbf58b89 · 2026-01-22T17:13:05.000+01:00
diff --git a/.github/workflows/check-easyjson.yml b/.github/workflows/check-easyjson.yml
@@ -2,7 +2,7 @@ name: Check easyjson generated files
 
 env:
   # See: https://github.com/actions/setup-go/tree/main#supported-version-syntax
-  GO_VERSION: "1.17"
+  GO_VERSION: "1.23.0"
 
 # See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
 on:
diff --git a/.github/workflows/check-go-task.yml b/.github/workflows/check-go-task.yml
@@ -3,7 +3,7 @@ name: Check Go
 
 env:
   # See: https://github.com/actions/setup-go/tree/main#supported-version-syntax
-  GO_VERSION: "1.17"
+  GO_VERSION: "1.23.0"
 
 # See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
 on:
diff --git a/.github/workflows/check-i18n-task.yml b/.github/workflows/check-i18n-task.yml
@@ -2,7 +2,7 @@ name: Check Internationalization
 
 env:
   # See: https://github.com/actions/setup-go/tree/main#supported-version-syntax
-  GO_VERSION: "1.17"
+  GO_VERSION: "1.23.0"
 
 # See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
 on:
diff --git a/.github/workflows/check-markdown-task.yml b/.github/workflows/check-markdown-task.yml
@@ -3,7 +3,7 @@ name: Check Markdown
 
 env:
   # See: https://github.com/actions/setup-go/tree/main#supported-version-syntax
-  GO_VERSION: "1.17"
+  GO_VERSION: "1.23.0"
 
 # See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
 on:
diff --git a/.github/workflows/check-mkdocs-task.yml b/.github/workflows/check-mkdocs-task.yml
@@ -3,7 +3,7 @@ name: Check Website
 
 env:
   # See: https://github.com/actions/setup-go/tree/main#supported-version-syntax
-  GO_VERSION: "1.17"
+  GO_VERSION: "1.23.0"
   # See: https://github.com/actions/setup-python/tree/main#available-versions-of-python
   PYTHON_VERSION: "3.9"
 
diff --git a/.github/workflows/check-protobuf-task.yml b/.github/workflows/check-protobuf-task.yml
@@ -2,7 +2,7 @@ name: Check Protocol Buffers
 
 env:
   # See: https://github.com/actions/setup-go/tree/main#supported-version-syntax
-  GO_VERSION: "1.17"
+  GO_VERSION: "1.23.0"
 
 # See: https://docs.github.com/en/actions/reference/events-that-trigger-workflows
 on:
diff --git a/.github/workflows/deploy-cobra-mkdocs-versioned-poetry.yml b/.github/workflows/deploy-cobra-mkdocs-versioned-poetry.yml
@@ -3,7 +3,7 @@ name: Deploy Website
 
 env:
   # See: https://github.com/actions/setup-go/tree/main#supported-version-syntax
-  GO_VERSION: "1.17"
+  GO_VERSION: "1.23.0"
   # See: https://github.com/actions/setup-python/tree/main#available-versions-of-python
   PYTHON_VERSION: "3.9"
 
diff --git a/.github/workflows/i18n-nightly-push.yaml b/.github/workflows/i18n-nightly-push.yaml
@@ -18,7 +18,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v3
         with:
-          go-version: "1.17"
+          go-version: "1.23.0"
 
       - name: Install Taskfile
         uses: arduino/setup-task@v1
diff --git a/.github/workflows/i18n-weekly-pull.yaml b/.github/workflows/i18n-weekly-pull.yaml
@@ -20,7 +20,7 @@ jobs:
       - name: Install Go
         uses: actions/setup-go@v3
         with:
-          go-version: "1.17"
+          go-version: "1.23.0"
 
       - name: Install Taskfile
         uses: arduino/setup-task@v1
diff --git a/.github/workflows/test-go-integration-task.yml b/.github/workflows/test-go-integration-task.yml
@@ -3,7 +3,7 @@ name: Test Integration
 
 env:
   # See: https://github.com/actions/setup-go/tree/main#supported-version-syntax
-  GO_VERSION: "1.17"
+  GO_VERSION: "1.23.0"
   # See: https://github.com/actions/setup-python/tree/main#available-versions-of-python
   PYTHON_VERSION: "3.9.6"
 
diff --git a/.github/workflows/test-go-task.yml b/.github/workflows/test-go-task.yml
@@ -3,7 +3,7 @@ name: Test Go
 
 env:
   # See: https://github.com/actions/setup-go/tree/main#supported-version-syntax
-  GO_VERSION: "1.17"
+  GO_VERSION: "1.23.0"
   COVERAGE_ARTIFACT: coverage-data
 
 # See: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows
diff --git a/arduino/cores/packageindex/index.go b/arduino/cores/packageindex/index.go
@@ -30,13 +30,15 @@ import (
 )
 
 // Index represents Cores and Tools struct as seen from package_index.json file.
+//
 //easyjson:json
 type Index struct {
 	Packages  []*indexPackage `json:"packages"`
 	IsTrusted bool
 }
 
 // indexPackage represents a single entry from package_index.json file.
+//
 //easyjson:json
 type indexPackage struct {
 	Name       string                  `json:"name"`
@@ -50,6 +52,7 @@ type indexPackage struct {
 }
 
 // indexPlatformRelease represents a single Core Platform from package_index.json file.
+//
 //easyjson:json
 type indexPlatformRelease struct {
 	Name                  string                     `json:"name"`
@@ -69,6 +72,7 @@ type indexPlatformRelease struct {
 }
 
 // indexToolDependency represents a single dependency of a core from a tool.
+//
 //easyjson:json
 type indexToolDependency struct {
 	Packager string                 `json:"packager"`
@@ -77,20 +81,23 @@ type indexToolDependency struct {
 }
 
 // indexDiscoveryDependency represents a single dependency of a core from a pluggable discovery tool.
+//
 //easyjson:json
 type indexDiscoveryDependency struct {
 	Packager string `json:"packager"`
 	Name     string `json:"name"`
 }
 
 // indexMonitorDependency represents a single dependency of a core from a pluggable monitor tool.
+//
 //easyjson:json
 type indexMonitorDependency struct {
 	Packager string `json:"packager"`
 	Name     string `json:"name"`
 }
 
 // indexToolRelease represents a single Tool from package_index.json file.
+//
 //easyjson:json
 type indexToolRelease struct {
 	Name    string                    `json:"name"`
@@ -99,6 +106,7 @@ type indexToolRelease struct {
 }
 
 // indexToolReleaseFlavour represents a single tool flavor in the package_index.json file.
+//
 //easyjson:json
 type indexToolReleaseFlavour struct {
 	OS              string      `json:"host"`
@@ -109,19 +117,22 @@ type indexToolReleaseFlavour struct {
 }
 
 // indexBoard represents a single Board as written in package_index.json file.
+//
 //easyjson:json
 type indexBoard struct {
 	Name string         `json:"name"`
 	ID   []indexBoardID `json:"id,omitempty"`
 }
 
 // indexBoardID represents the ID of a single board. i.e. uno, yun, diecimila, micro and the likes
+//
 //easyjson:json
 type indexBoardID struct {
 	USB string `json:"usb"`
 }
 
 // indexHelp represents the help URL
+//
 //easyjson:json
 type indexHelp struct {
 	Online string `json:"online,omitempty"`
diff --git a/arduino/security/signatures.go b/arduino/security/signatures.go
@@ -64,7 +64,9 @@ func VerifyDetachedSignature(targetPath *paths.Path, signaturePath *paths.Path,
 // VerifySignature checks that the detached GPG signature (in the
 // signaturePath file) matches the given targetPath file and is an authentic
 // signature. This function allows to pass an io.Reader to read the custom key.
-//  If any of the above conditions fails this function returns false.
+//
+//	If any of the above conditions fails this function returns false.
+//
 // The PGP entity in the trusted keychain that produced the signature is returned too.
 func VerifySignature(targetPath *paths.Path, signaturePath *paths.Path, arduinoKeyringFile io.Reader) (bool, *openpgp.Entity, error) {
 	keyRing, err := openpgp.ReadKeyRing(arduinoKeyringFile)
diff --git a/arduino/sketch/sketch.go b/arduino/sketch/sketch.go
@@ -252,10 +252,13 @@ func (s *Sketch) GetProfile(profileName string) *Profile {
 
 // checkSketchCasing returns an error if the casing of the sketch folder and the main file are different.
 // Correct:
-//    MySketch/MySketch.ino
+//
+//	MySketch/MySketch.ino
+//
 // Wrong:
-//    MySketch/mysketch.ino
-//    mysketch/MySketch.ino
+//
+//	MySketch/mysketch.ino
+//	mysketch/MySketch.ino
 //
 // This is mostly necessary to avoid errors on Mac OS X.
 // For more info see: https://github.com/arduino/arduino-cli/issues/1174
diff --git a/cli/arguments/fqbn.go b/cli/arguments/fqbn.go
@@ -69,9 +69,9 @@ func (f *Fqbn) Set(fqbn string) {
 // - it tries to autodetect the board connected to the given port flags
 // If all above methods fails, it returns the empty string.
 // The Port metadata are always returned except if:
-// - the port is not found, in this case nil is returned
-// - the FQBN autodetection fail, in this case the function prints an error and
-//   terminates the execution
+//   - the port is not found, in this case nil is returned
+//   - the FQBN autodetection fail, in this case the function prints an error and
+//     terminates the execution
 func CalculateFQBNAndPort(portArgs *Port, fqbnArg *Fqbn, instance *rpc.Instance, sk *sketch.Sketch) (string, *rpc.Port) {
 	// TODO: REMOVE sketch.Sketch from here
 
diff --git a/commands/daemon/settings.go b/commands/daemon/settings.go
@@ -46,9 +46,12 @@ func (s *SettingsService) GetAll(ctx context.Context, req *rpc.GetAllRequest) (*
 
 // mapper converts a map of nested maps to a map of scalar values.
 // For example:
-//    {"foo": "bar", "daemon":{"port":"420"}, "sketch": {"always_export_binaries": "true"}}
+//
+//	{"foo": "bar", "daemon":{"port":"420"}, "sketch": {"always_export_binaries": "true"}}
+//
 // would convert to:
-//    {"foo": "bar", "daemon.port":"420", "sketch.always_export_binaries": "true"}
+//
+//	{"foo": "bar", "daemon.port":"420", "sketch.always_export_binaries": "true"}
 func mapper(toMap map[string]interface{}) map[string]interface{} {
 	res := map[string]interface{}{}
 	for k, v := range toMap {
diff --git a/commands/upload/upload.go b/commands/upload/upload.go
@@ -629,11 +629,13 @@ func detectSketchNameFromBuildPath(buildPath *paths.Path) (string, error) {
 // specified protocol properties.
 //
 // For example passing the below properties and "upload" as action and "serial" as protocol:
+//
 //	upload.speed=256
 //	upload.serial.speed=57600
 //	upload.network.speed=19200
 //
 // will return:
+//
 //	upload.speed=57600
 //	upload.serial.speed=57600
 //	upload.network.speed=19200
diff --git a/i18n/convert.go b/i18n/convert.go
@@ -26,7 +26,7 @@ var javaFormatPlaceholderRegexp = regexp.MustCompile(`{(\d)}`)
 // FromJavaToGoSyntax convert a translation string made for Java to a one suitable for golang (printf-style).
 // The conversion transforms java placeholders like "{0}","{1}","{2}",etc... with the equivalent for golang
 // "%[1]v","%[2]v","%[3]v",etc...
-// The double single-quote "''" is translated into a single single-quote "'".
+// The double single-quote "”" is translated into a single single-quote "'".
 func FromJavaToGoSyntax(s string) string {
 	// Replace "{x}" => "%[x+1]v"
 	for _, submatch := range javaFormatPlaceholderRegexp.FindAllStringSubmatch(s, -1) {
diff --git a/rpc/cc/arduino/cli/debug/v1/debug.pb.go b/rpc/cc/arduino/cli/debug/v1/debug.pb.go
diff --git a/version/version_test.go b/version/version_test.go
@@ -23,9 +23,10 @@ import (
 
 // TestBuildInjectedInfo tests the Info strings passed to the binary at build time
 // in order to have this test green launch your testing using the provided task (see /Taskfile.yml) or use:
-//     go test -run TestBuildInjectedInfo -v ./... -ldflags '
-//       -X github.com/arduino/arduino-cli/version.versionString=0.0.0-test.preview
-//       -X github.com/arduino/arduino-cli/version.commit=deadbeef'
+//
+//	go test -run TestBuildInjectedInfo -v ./... -ldflags '
+//	  -X github.com/arduino/arduino-cli/version.versionString=0.0.0-test.preview
+//	  -X github.com/arduino/arduino-cli/version.commit=deadbeef'
 func TestBuildInjectedInfo(t *testing.T) {
 	goldenAppName := "arduino-cli"
 	goldenInfo := Info{
