fix: appese govet linter

non-constant format string in call. We were calling some format
function, but we were always passing a "static" string.

Author: alessio-perugini

commands/instances.go

@@ -340,7 +340,7 @@ func (s *arduinoCoreServerImpl) Init(req *rpc.InitRequest, stream rpc.ArduinoCor
 	logrus.WithField("index", indexFile).Info("Loading libraries index file")
 	li, err := librariesindex.LoadIndex(indexFile)
 	if err != nil {
-		s := status.Newf(codes.FailedPrecondition, i18n.Tr("Loading index file: %v", err))
+		s := status.New(codes.FailedPrecondition, i18n.Tr("Loading index file: %v", err))
 		responseError(s)
 		li = librariesindex.EmptyIndex
 	}

internal/arduino/builder/recipe.go

@@ -16,7 +16,6 @@
 package builder
 
 import (
-	"fmt"
 	"sort"
 	"strings"
 
@@ -27,7 +26,7 @@ import (
 
 // RunRecipe fixdoc
 func (b *Builder) RunRecipe(prefix, suffix string, skipIfOnlyUpdatingCompilationDatabase bool) error {
-	logrus.Debugf(fmt.Sprintf("Looking for recipes like %s", prefix+"*"+suffix))
+	logrus.Debugf("Looking for recipes like %s", prefix+"*"+suffix)
 
 	// TODO is it necessary to use Clone?
 	buildProperties := b.buildProperties.Clone()
@@ -36,7 +35,7 @@ func (b *Builder) RunRecipe(prefix, suffix string, skipIfOnlyUpdatingCompilation
 	// TODO is it necessary to use Clone?
 	properties := buildProperties.Clone()
 	for _, recipe := range recipes {
-		logrus.Debugf(fmt.Sprintf("Running recipe: %s", recipe))
+		logrus.Debugf("Running recipe: %s", recipe)
 
 		command, err := b.prepareCommandForRecipe(properties, recipe, false)
 		if err != nil {

internal/arduino/libraries/librariesmanager/librariesmanager.go

@@ -210,7 +210,7 @@ func (lm *LibrariesManager) loadLibrariesFromDir(librariesDir *LibrariesDir) []*
 			return statuses
 		}
 		if err != nil {
-			s := status.Newf(codes.FailedPrecondition, i18n.Tr("reading dir %[1]s: %[2]s", librariesDir.Path, err))
+			s := status.New(codes.FailedPrecondition, i18n.Tr("reading dir %[1]s: %[2]s", librariesDir.Path, err))
 			return append(statuses, s)
 		}
 		d.FilterDirs()
@@ -221,7 +221,7 @@ func (lm *LibrariesManager) loadLibrariesFromDir(librariesDir *LibrariesDir) []*
 	for _, libDir := range libDirs {
 		library, err := libraries.Load(libDir, librariesDir.Location)
 		if err != nil {
-			s := status.Newf(codes.Internal, i18n.Tr("loading library from %[1]s: %[2]s", libDir, err))
+			s := status.New(codes.Internal, i18n.Tr("loading library from %[1]s: %[2]s", libDir, err))
 			statuses = append(statuses, s)
 			continue
 		}

internal/arduino/libraries/librariesresolver/cpp.go

@@ -123,7 +123,7 @@ func (resolver *Cpp) ResolveFor(header, architecture string) *libraries.Library
 		logrus.
 			WithField("lib", lib.Name).
 			WithField("prio", fmt.Sprintf("%03X", libPriority)).
-			Infof(msg)
+			Info(msg)
 	}
 	if found == nil {
 		return nil