Merge branch 'master' into fix/sketch-name-validation

Author: Luca Bianconi

Diff for: docs/UPGRADING.md

@@ -11,6 +11,10 @@ The sketch name submitted via the `sketch new` command of the CLI or the gRPC co
 [sketch specifications](https://arduino.github.io/arduino-cli/dev/sketch-specification).
 
 Existing sketch names that don't respect the new constraints need to be updated.
+### `daemon` CLI command's `--ip` flag removal
+
+The `daemon` CLI command no longer allows to set a custom ip for the gRPC communication. Currently there is not enough
+bandwith to support this feature. For this reason, the `--ip` flag has been removed.
 
 ### `board attach` CLI command changed behaviour
 

Diff for: internal/cli/daemon/daemon.go

@@ -39,7 +39,6 @@ import (
 
 var (
 	tr           = i18n.Tr
-	ip           string
 	daemonize    bool
 	debug        bool
 	debugFile    string
@@ -56,7 +55,6 @@ func NewCommand() *cobra.Command {
 		Args:    cobra.NoArgs,
 		Run:     runDaemonCommand,
 	}
-	daemonCommand.PersistentFlags().StringVar(&ip, "ip", "127.0.0.1", tr("The IP address the daemon will listen to"))
 	daemonCommand.PersistentFlags().String("port", "", tr("The TCP port the daemon will listen to"))
 	configuration.Settings.BindPFlag("daemon.port", daemonCommand.PersistentFlags().Lookup("port"))
 	daemonCommand.Flags().BoolVar(&daemonize, "daemonize", false, tr("Do not terminate daemon process if the parent process dies"))
@@ -120,6 +118,7 @@ func runDaemonCommand(cmd *cobra.Command, args []string) {
 		go feedback.ExitWhenParentProcessEnds()
 	}
 
+	ip := "127.0.0.1"
 	lis, err := net.Listen("tcp", fmt.Sprintf("%s:%s", ip, port))
 	if err != nil {
 		// Invalid port, such as "Foo"