Skip to content

Commit 1b9c4c4

Browse files
committed
Don't upload multiple times to same artifact in label sync workflow
The "Sync Labels" GitHub Actions workflow is configured to allow the use of multiple shared label configuration files. This is done by using a job matrix in the GitHub Actions workflow to download each of the files from the source repository in a parallel GitHub Actions workflow job. A GitHub Actions workflow artifact was used to transfer the generated files between sequential jobs in the workflow. The "actions/upload-artifact" and "actions/download-artifact" actions are used for this purpose. Previously, a single artifact was used for the transfer of all the shared label configuration files, with each of the parallel jobs uploading its own generated files to that artifact. However, support for uploading multiple times to a single artifact was dropped in version 4.0.0 of the "actions/upload-artifact" action. So it is now necessary to use a dedicated artifact for each of the builds. These can be downloaded in aggregate by using the artifact name globbing and merging features which were introduced in version 4.1.0 of the "actions/download-artifact" action.
1 parent ce3cef9 commit 1b9c4c4

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

.github/workflows/sync-labels.yml

+7-6
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ on:
1919

2020
env:
2121
CONFIGURATIONS_FOLDER: .github/label-configuration-files
22-
CONFIGURATIONS_ARTIFACT: label-configuration-files
22+
CONFIGURATIONS_ARTIFACT_PREFIX: label-configuration-file-
2323

2424
jobs:
2525
check:
@@ -76,7 +76,7 @@ jobs:
7676
*.yaml
7777
*.yml
7878
if-no-files-found: error
79-
name: ${{ env.CONFIGURATIONS_ARTIFACT }}
79+
name: ${{ env.CONFIGURATIONS_ARTIFACT_PREFIX }}${{ matrix.filename }}
8080

8181
sync:
8282
needs: download
@@ -107,16 +107,17 @@ jobs:
107107
- name: Checkout repository
108108
uses: actions/checkout@v4
109109

110-
- name: Download configuration files artifact
110+
- name: Download configuration file artifacts
111111
uses: actions/download-artifact@v4
112112
with:
113-
name: ${{ env.CONFIGURATIONS_ARTIFACT }}
113+
merge-multiple: true
114+
pattern: ${{ env.CONFIGURATIONS_ARTIFACT_PREFIX }}*
114115
path: ${{ env.CONFIGURATIONS_FOLDER }}
115116

116-
- name: Remove unneeded artifact
117+
- name: Remove unneeded artifacts
117118
uses: geekyeggo/delete-artifact@v5
118119
with:
119-
name: ${{ env.CONFIGURATIONS_ARTIFACT }}
120+
name: ${{ env.CONFIGURATIONS_ARTIFACT_PREFIX }}*
120121

121122
- name: Merge label configuration files
122123
run: |

0 commit comments

Comments
 (0)