Skip to content

Commit 676b255

Browse files
author
Akos Kitta
committed
merged in realTimeDiagnostics support.
Signed-off-by: Akos Kitta <[email protected]>
1 parent 824e55c commit 676b255

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

Diff for: arduino-ide-extension/src/browser/contributions/ino-language.ts

+14-9
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,14 @@ export class InoLanguage extends SketchContribution {
3232
private languageServerStartMutex = new Mutex();
3333

3434
override onReady(): void {
35-
const start = ({ selectedBoard }: BoardsConfig.Config) => {
35+
const start = (
36+
{ selectedBoard }: BoardsConfig.Config,
37+
forceStart = false
38+
) => {
3639
if (selectedBoard) {
3740
const { name, fqbn } = selectedBoard;
3841
if (fqbn) {
39-
this.startLanguageServer(fqbn, name);
42+
this.startLanguageServer(fqbn, name, forceStart);
4043
}
4144
}
4245
};
@@ -49,11 +52,12 @@ export class InoLanguage extends SketchContribution {
4952
);
5053
this.preferences.onPreferenceChanged(
5154
({ preferenceName, oldValue, newValue }) => {
52-
if (
53-
preferenceName === 'arduino.language.log' &&
54-
newValue !== oldValue
55-
) {
56-
start(this.boardsServiceProvider.boardsConfig);
55+
if (oldValue !== newValue) {
56+
switch (preferenceName) {
57+
case 'arduino.language.log':
58+
case 'arduino.language.realTimeDiagnostics':
59+
start(this.boardsServiceProvider.boardsConfig, true);
60+
}
5761
}
5862
}
5963
);
@@ -62,7 +66,8 @@ export class InoLanguage extends SketchContribution {
6266

6367
private async startLanguageServer(
6468
fqbn: string,
65-
name: string | undefined
69+
name: string | undefined,
70+
forceStart = false
6671
): Promise<void> {
6772
const port = await this.daemon.tryGetPort();
6873
if (!port) {
@@ -96,7 +101,7 @@ export class InoLanguage extends SketchContribution {
96101
}
97102
return;
98103
}
99-
if (fqbn === this.languageServerFqbn) {
104+
if (!forceStart && fqbn === this.languageServerFqbn) {
100105
// NOOP
101106
return;
102107
}

0 commit comments

Comments
 (0)