Skip to content

Commit 7a12159

Browse files
author
Alberto Iannaccone
committed
fix dialogs width when scaling up the UI
1 parent 19c8a07 commit 7a12159

File tree

6 files changed

+13
-5
lines changed

6 files changed

+13
-5
lines changed

Diff for: arduino-ide-extension/src/browser/dialogs/certificate-uploader/certificate-uploader-dialog.tsx

+6-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
import * as React from '@theia/core/shared/react';
2-
import { inject, injectable, postConstruct } from '@theia/core/shared/inversify';
2+
import {
3+
inject,
4+
injectable,
5+
postConstruct,
6+
} from '@theia/core/shared/inversify';
37
import { DialogProps } from '@theia/core/lib/browser/dialogs';
48
import { AbstractDialog } from '../../theia/dialogs/dialogs';
59
import { Widget } from '@theia/core/shared/@phosphor/widgets';
@@ -153,6 +157,7 @@ export class UploadCertificateDialog extends AbstractDialog<void> {
153157
'Upload SSL Root Certificates'
154158
),
155159
});
160+
this.node.id = 'certificate-uploader-dialog-container';
156161
this.contentNode.classList.add('certificate-uploader-dialog');
157162
this.acceptButton = undefined;
158163
}

Diff for: arduino-ide-extension/src/browser/dialogs/firmware-uploader/firmware-uploader-dialog.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ export class UploadFirmwareDialog extends AbstractDialog<void> {
101101
protected override readonly props: UploadFirmwareDialogProps
102102
) {
103103
super({ title: UploadFirmware.Commands.OPEN.label || '' });
104+
this.node.id = 'firmware-uploader-dialog-container';
104105
this.contentNode.classList.add('firmware-uploader-dialog');
105106
this.acceptButton = undefined;
106107
}

Diff for: arduino-ide-extension/src/browser/dialogs/ide-updater/ide-updater-dialog.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,7 @@ export class IDEUpdaterDialog extends AbstractDialog<UpdateInfo> {
130130
'Software Update'
131131
),
132132
});
133+
this.node.id = 'ide-updater-dialog-container';
133134
this.contentNode.classList.add('ide-updater-dialog');
134135
this.acceptButton = undefined;
135136
}

Diff for: arduino-ide-extension/src/browser/style/certificate-uploader-dialog.css

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
.certificate-uploader-dialog {
1+
#certificate-uploader-dialog-container > .dialogBlock {
22
width: 600px;
33
}
44

Diff for: arduino-ide-extension/src/browser/style/firmware-uploader-dialog.css

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
.firmware-uploader-dialog {
1+
#firmware-uploader-dialog-container > .dialogBlock {
22
width: 600px;
33
}
44

@@ -11,7 +11,6 @@
1111
}
1212

1313
.firmware-uploader-dialog .dialogRow > button{
14-
width: 33%;
1514
margin-right: 3px;
1615
}
1716

Diff for: arduino-ide-extension/src/browser/style/ide-updater-dialog.css

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
.ide-updater-dialog {
1+
#ide-updater-dialog-container > .dialogBlock {
22
width: 546px;
33
}
44

@@ -24,6 +24,8 @@
2424
.ide-updater-dialog--content
2525
.ide-updater-dialog--new-version-text.dialogSection {
2626
margin-top: 0;
27+
flex: 1;
28+
min-width: 0;
2729
}
2830

2931
.ide-updater-dialog .changelog-container {

0 commit comments

Comments
 (0)