Skip to content

Commit a679e8f

Browse files
author
Akos Kitta
committed
test: do not run slow tests on i18n check
Signed-off-by: Akos Kitta <[email protected]>
1 parent 61f8f8a commit a679e8f

File tree

5 files changed

+11
-12
lines changed

5 files changed

+11
-12
lines changed

arduino-ide-extension/package.json

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"build": "tsc && ncp ./src/node/cli-protocol/ ./lib/node/cli-protocol/ && yarn lint",
1818
"watch": "tsc -w",
1919
"test": "mocha \"./lib/test/**/*.test.js\"",
20+
"test:slow": "mocha \"./lib/test/**/*.slow-test.js\"",
2021
"test:watch": "mocha --watch --watch-files lib \"./lib/test/**/*.test.js\""
2122
},
2223
"dependencies": {

arduino-ide-extension/src/node/core-client-provider.ts

-5
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ export class CoreClientProvider {
6363
new Emitter<CoreClientProvider.Client>();
6464
private readonly onClientReady = this.onClientReadyEmitter.event;
6565

66-
private ready = new Deferred<void>();
6766
private pending: Deferred<CoreClientProvider.Client> | undefined;
6867
private _client: CoreClientProvider.Client | undefined;
6968

@@ -135,10 +134,6 @@ export class CoreClientProvider {
135134
const client = await this.createClient(address);
136135
this.toDisposeOnCloseClient.pushAll([
137136
Disposable.create(() => client.client.close()),
138-
Disposable.create(() => {
139-
this.ready.resolve();
140-
this.ready = new Deferred();
141-
}),
142137
]);
143138
await this.initInstanceWithFallback(client);
144139
return this.useClient(client);

arduino-ide-extension/src/test/node/core-service-impl.test.ts arduino-ide-extension/src/test/node/core-service-impl.slow-test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ import {
5656
import { SketchesServiceImpl } from '../../node/sketches-service-impl';
5757
import { EnvVariablesServer } from '../../node/theia/env-variables/env-variables-server';
5858

59-
const timeout = 50_000;
59+
const timeout = 100_000;
6060
const avr = 'arduino:avr';
6161
const uno = 'arduino:avr:uno';
6262

electron/packager/index.js

+8-6
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,13 @@
107107
`yarn --network-timeout 1000000 --cwd ${join(repoRoot, extension)}`,
108108
`Building and testing ${extension}`
109109
);
110+
exec(
111+
`yarn --network-timeout 1000000 --cwd ${join(
112+
repoRoot,
113+
extension
114+
)} test:slow`,
115+
`Executing slow tests ${extension}`
116+
);
110117
}
111118

112119
//------------------------+
@@ -434,12 +441,7 @@ ${fs
434441
* @param {BufferEncoding|undefined} [encoding="base64"]
435442
* @param {object|undefined} [options]
436443
*/
437-
function hashFile(
438-
file,
439-
algorithm = 'sha512',
440-
encoding = 'base64',
441-
options
442-
) {
444+
function hashFile(file, algorithm = 'sha512', encoding = 'base64', options) {
443445
const crypto = require('crypto');
444446
return new Promise((resolve, reject) => {
445447
const hash = crypto.createHash(algorithm);

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
"start": "yarn --cwd ./electron-app start",
4949
"watch": "lerna run watch --parallel",
5050
"test": "lerna run test",
51+
"test:slow": "lerna run test:slow",
5152
"download:plugins": "theia download:plugins",
5253
"update:version": "node ./scripts/update-version.js",
5354
"i18n:generate": "theia nls-extract -e vscode -f \"+(arduino-ide-extension|electron-app|plugins)/**/*.ts?(x)\" -o ./i18n/en.json",

0 commit comments

Comments
 (0)