fix: can open IDE2 from an ino file

With the previous electron version update, the app start lifecycle has
changed, and when the application is launched with args (such as when
starting IDE2 from a terminal `#launchFromArgs`), the `start` method is
not called, and the frontend application config is not injected into the
electron app from the generated electron main code. This PR makes the
frontend application config access resilient.

Closes #2209

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

arduino-ide-extension/src/electron-main/theia/electron-main-application.ts

@@ -27,7 +27,7 @@ import { log as logToFile, setup as setupFileLog } from 'node-log-rotate';
 import { fork } from 'node:child_process';
 import { promises as fs, rm, rmSync } from 'node:fs';
 import type { AddressInfo } from 'node:net';
-import { isAbsolute, join, resolve } from 'node:path';
+import path from 'node:path';
 import { Sketch } from '../../common/protocol';
 import {
   AppInfo,
@@ -226,9 +226,12 @@ export class ElectronMainApplication extends TheiaElectronMainApplication {
       const appPath = app.getAppPath();
       let traceFile: string | undefined;
       if (appPath) {
-        const tracesPath = join(appPath, 'traces');
+        const tracesPath = path.join(appPath, 'traces');
         await fs.mkdir(tracesPath, { recursive: true });
-        traceFile = join(tracesPath, `trace-${new Date().toISOString()}.trace`);
+        traceFile = path.join(
+          tracesPath,
+          `trace-${new Date().toISOString()}.trace`
+        );
       }
       console.log('>>> Content tracing has started...');
       await contentTracing.startRecording(traceOptions);
@@ -270,11 +273,11 @@ export class ElectronMainApplication extends TheiaElectronMainApplication {
     maybePath: string,
     cwd: string
   ): Promise<string | undefined> {
-    if (isAbsolute(maybePath)) {
+    if (path.isAbsolute(maybePath)) {
       return maybePath;
     }
     try {
-      const resolved = await fs.realpath(resolve(cwd, maybePath));
+      const resolved = await fs.realpath(path.resolve(cwd, maybePath));
       return resolved;
     } catch (err) {
       if (ErrnoException.isENOENT(err)) {
@@ -505,13 +508,38 @@ export class ElectronMainApplication extends TheiaElectronMainApplication {
   }
 
   protected override getDefaultOptions(): TheiaBrowserWindowOptions {
-    const options = super.getDefaultOptions();
-    if (!options.webPreferences) {
-      options.webPreferences = {};
-    }
-    options.webPreferences.v8CacheOptions = 'bypassHeatCheck'; // TODO: verify this. VS Code use this V8 option.
-    options.minWidth = 680;
-    options.minHeight = 593;
+    // When opening IDE2 by double clicking on the ino file (for example, from Finder or Explorer), the frontend app config is not yet set.
+    // This customized default options method ensures that getting the frontend config is failsafe.
+    // https://github.com/arduino/arduino-ide/pull/2287#issuecomment-1818828569
+    const config = this._config ?? {
+      applicationName: '',
+      electron: { windowOptions: {} },
+    };
+    const options: TheiaBrowserWindowOptions = {
+      show: false,
+      title: config.applicationName,
+      minWidth: 680,
+      minHeight: 593,
+      webPreferences: {
+        // `global` is undefined when `true`.
+        contextIsolation: true,
+        sandbox: false,
+        nodeIntegration: false,
+        // Setting the following option to `true` causes some features to break, somehow.
+        // Issue: https://github.com/eclipse-theia/theia/issues/8577
+        nodeIntegrationInWorker: false,
+        preload: path
+          .resolve(
+            this.globals.THEIA_APP_PROJECT_PATH,
+            'lib',
+            'frontend',
+            'preload.js'
+          )
+          .toString(),
+        v8CacheOptions: 'bypassHeatCheck', // TODO: verify this. VS Code use this V8 option.
+      },
+      ...(config.electron?.windowOptions || {}),
+    };
     return options;
   }
 
@@ -777,7 +805,13 @@ async function updateFrontendApplicationConfigFromPackageJson(
   try {
     const modulePath = __filename;
     // must go from `./lib/backend/electron-main.js` to `./package.json` when the app is webpacked.
-    const packageJsonPath = join(modulePath, '..', '..', '..', 'package.json');
+    const packageJsonPath = path.join(
+      modulePath,
+      '..',
+      '..',
+      '..',
+      'package.json'
+    );
     console.debug(
       `Checking for frontend application configuration customizations. Module path: ${modulePath}, destination 'package.json': ${packageJsonPath}`
     );