use arduio-cli sorting fix

Author: Alberto Iannaccone

Diff for: arduino-ide-extension/src/browser/contributions/board-selection.ts

@@ -361,7 +361,7 @@ PID: ${PID}`;
   }
 
   protected async installedBoards(): Promise<InstalledBoardWithPackage[]> {
-    const allBoards = await this.boardsService.searchBoards({});
+    const allBoards = await this.boardsService.getInstalledBoards();
     return allBoards.filter(InstalledBoardWithPackage.is);
   }
 }

Diff for: arduino-ide-extension/src/common/protocol/boards-service.ts

@@ -141,6 +141,7 @@ export interface BoardsService
     fqbn: string;
   }): Promise<BoardsPackage | undefined>;
   searchBoards({ query }: { query?: string }): Promise<BoardWithPackage[]>;
+  getInstalledBoards(): Promise<BoardWithPackage[]>;
   getBoardUserFields(options: {
     fqbn: string;
     protocol: string;

Diff for: arduino-ide-extension/src/node/boards-service-impl.ts

@@ -33,6 +33,7 @@ import {
   BoardDetailsRequest,
   BoardDetailsResponse,
   BoardListAllRequest,
+  BoardSearchRequest,
 } from './cli-protocol/cc/arduino/cli/commands/v1/board_pb';
 import {
   ListProgrammersAvailableForUploadRequest,
@@ -195,9 +196,38 @@ export class BoardsServiceImpl
   }: {
     query?: string;
   }): Promise<BoardWithPackage[]> {
+    const { instance, client } = await this.coreClient;
+    const req = new BoardSearchRequest();
+    req.setSearchArgs(query || '');
+    req.setInstance(instance);
+    const boards = await new Promise<BoardWithPackage[]>((resolve, reject) => {
+      client.boardSearch(req, (error, resp) => {
+        if (error) {
+          reject(error);
+          return;
+        }
+        const boards: Array<BoardWithPackage> = [];
+        for (const board of resp.getBoardsList()) {
+          const platform = board.getPlatform();
+          if (platform) {
+            boards.push({
+              name: board.getName(),
+              fqbn: board.getFqbn(),
+              packageId: platform.getId(),
+              packageName: platform.getName(),
+              manuallyInstalled: platform.getManuallyInstalled(),
+            });
+          }
+        }
+        resolve(boards);
+      });
+    });
+    return boards;
+  }
+
+  async getInstalledBoards(): Promise<BoardWithPackage[]> {
     const { instance, client } = await this.coreClient;
     const req = new BoardListAllRequest();
-    req.addSearchArgs(query || '');
     req.setInstance(instance);
     const boards = await new Promise<BoardWithPackage[]>((resolve, reject) => {
       client.boardListAll(req, (error, resp) => {