Skip to content

Fix dialogs UI scalability vol 2 - Unexpected dialog layouts #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
kittaakos opened this issue Aug 24, 2022 · 8 comments · Fixed by #1406
Closed
3 tasks done

Fix dialogs UI scalability vol 2 - Unexpected dialog layouts #1350

kittaakos opened this issue Aug 24, 2022 · 8 comments · Fixed by #1406
Assignees
Labels
criticality: medium Of moderate impact topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Aug 24, 2022

Describe the problem

This is a follow-up of #1311.

Several dialogs have an unexpected layout.

  • If the board name is long, the board select dialog is ugly
    Screenshot 2022-08-23 at 17 15 08
  • The new file dialog is too small. Start typing and use an unsupported file extension. The dialog grows with the validation error message.
    Screen Shot 2022-08-24 at 16 30 48

To reproduce

See above

Expected behavior

The dialogs look the same as before #1311

Arduino IDE version

Version: 2.0.0-rc9.2.nightly-20220824 Date: 2022-08-24T03:48:57.272Z CLI Version: git-snapshot [04e70c53] Copyright © 2022 Arduino SA

Operating system

macOS

Operating system version

12.5.1

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Aug 24, 2022
@ubidefeo
Copy link

I have taken more screenshots since the size of this dialog changes as you type

CleanShot 2022-08-25 at 16 29 13@2x

CleanShot 2022-08-25 at 16 29 32@2x

CleanShot 2022-08-25 at 16 29 44@2x

@Volt23
Copy link

Volt23 commented Aug 26, 2022

This and the Preferences dialog should have a fixed width of 640px, we have a min size window set to 680px, making this size safe when resizing the workspace.

The new tab dialog should have a fixed width of 480px.

@kittaakos
Copy link
Contributor Author

new tab dialog

Why the new tab only? What about rename, etc.

@Volt23
Copy link

Volt23 commented Aug 29, 2022

@kittaakos
All simple dialogs - with one input only - should be 480px fixed width. In this specific case of the tabs' contextual menu the dialogs are: New tab, Rename and Delete.

@kittaakos
Copy link
Contributor Author

Boards list is getting smaller as I filter.

boards_select__when_typing.mp4

@kittaakos
Copy link
Contributor Author

Boards list is getting smaller as I filter.

The dialog and the internal port list also change when I toggle Show all ports:

boards_select__ports.mp4

@per1234
Copy link
Contributor

per1234 commented Sep 16, 2022

Describe the problem

Width of "Enter additional URLs, one for each row" field of "Additional Boards Manager URLs" dialog is not correctly sized relative to dialog width.

To reproduce

  1. Select File > Preferences from the Arduino IDE menus.
  2. Click the button on the right side of the "Additional Boards Manager URLs" field.

🐛 There is an horizontal scrollbar under the "Enter additional URLs, one for each row" field.
🐛 The user must scroll the field horizontally in order to access the field resize control.

additional-boards-manager-urls

Arduino IDE version

2.0.0-rc9.3.snapshot-d8377e0 (tester build for 5197920)

Operating system

Windows 10

Additional context

Originally reported at #1444


Note also the ugly lack of spacing between the bottom of the scroll bar and the top of the dialog's buttons.

@kittaakos
Copy link
Contributor Author

Width of "Enter additional URLs, one for each row" field of "Additional Boards Manager URLs" dialog is not correctly sized relative to dialog width.

See the fix here: #1382 (review).

Note that this is a partial fix, as the left and the right border are missing from the <textarea>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
criticality: medium Of moderate impact topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants