Skip to content

Assembly language file extension has the wrong case #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
per1234 opened this issue Mar 14, 2021 · 1 comment · Fixed by #263
Closed

Assembly language file extension has the wrong case #218

per1234 opened this issue Mar 14, 2021 · 1 comment · Fixed by #263
Labels
conclusion: resolved Issue was resolved criticality: low Of low impact topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Mar 14, 2021

Describe the bug
The Arduino build system requires assembly language files to use the .S file extension but the "New Tab" dialog only allows .s. Files using the .s extension are not compiled.

To Reproduce

  1. Click the downward pointing triangle button on the right side of the tab bar.
  2. Click "New Tab"
  3. In the "Name for new file" dialog, type "Foo.S". - ".S is not a valid file extension." is shown and the "OK" button is disabled.

Expected behavior
The .S file extension to be allowed and the .s extension prohibited by the "New Tab" and "Rename" dialogs of the tab control menu.

Desktop (please complete the following information):

  • OS: Windows 10
  • Version: 2.0.0-beta.3-nightly.20210313
    Date: 2021-03-13T03:11:23.309Z
    CLI Version: 0.16.1 alpha [76f55490]

Additional context
Reference from the Arduino Sketch Specification: https://arduino.github.io/arduino-cli/latest/sketch-specification/#additional-code-files

I believe the relevant code is here:

export const SOURCE = ['.c', '.cpp', '.s'];
export const ADDITIONAL = ['.h', '.c', '.hpp', '.hh', '.cpp', '.s', '.json'];

@per1234 per1234 added type: bug topic: code Related to content of the project itself labels Mar 14, 2021
@ubidefeo ubidefeo added the priority: low Resolution is a low priority label Mar 19, 2021
@fstasi fstasi linked a pull request Mar 25, 2021 that will close this issue
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@per1234 per1234 added the conclusion: resolved Issue was resolved label Oct 28, 2021
@rsora rsora added criticality: low Of low impact and removed priority: low Resolution is a low priority labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved criticality: low Of low impact topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants