Skip to content

The Windows build is broken for external contributors #2545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
dankeboy36 opened this issue Oct 28, 2024 · 0 comments · Fixed by #2554
Closed
3 tasks done

The Windows build is broken for external contributors #2545

dankeboy36 opened this issue Oct 28, 2024 · 0 comments · Fixed by #2554
Labels
conclusion: resolved Issue was resolved os: windows Specific to Windows operating system topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project

Comments

@dankeboy36
Copy link
Contributor

Describe the problem

Originally from #2543 (comment):

The build failure is most likely unrelated to the proposed changes; the CI must not sign the builds from forks:

Custom windows signing was no performed one of the following variables was not provided: SIGNTOOL_PATH (C:/Program Files (x86)/Windows Kits/10/bin/10.0.19041.0/x86/signtool.exe), INSTALLER_CERT_WINDOWS_CERT (C:/Users/Utente/AppData/Local/Temp/cert.cer), CERT_PASSWORD (), CONTAINER_NAME ()

I recognize that the team is small and that code reviews do not receive enough attention from maintainers. However, this CI error effectively blocks collaboration on the project.

To reproduce

Open a PR from a fork. The PR must include code changes. For example, changing markdown files won't trigger an electron build. See #2543 as an example.

Expected behavior

The Windows signing does not run on PRs opened from forks.

Or

The Windows signing works.

Arduino IDE version

3ccc864

Operating system

Windows

Operating system version

It's a CI

Additional context

Breaking change: 2e78e96.

CIs are smart to mask secrets, but I would probably remove the password printing to the console when not all envs are truthy.

`Custom windows signing was no performed one of the following variables was not provided: SIGNTOOL_PATH (${SIGNTOOL_PATH}), INSTALLER_CERT_WINDOWS_CERT (${INSTALLER_CERT_WINDOWS_CER}), CERT_PASSWORD (${CERT_PASSWORD}), CONTAINER_NAME (${CONTAINER_NAME})`

There is a typo in the console log.

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@dankeboy36 dankeboy36 added the type: imperfection Perceived defect in any part of project label Oct 28, 2024
@per1234 per1234 added topic: infrastructure Related to project infrastructure os: windows Specific to Windows operating system labels Oct 28, 2024
giacomocusinato added a commit to giacomocusinato/arduino-ide that referenced this issue Nov 7, 2024
@per1234 per1234 added the conclusion: resolved Issue was resolved label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved os: windows Specific to Windows operating system topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants