The Windows build is broken for external contributors #2545
Labels
conclusion: resolved
Issue was resolved
os: windows
Specific to Windows operating system
topic: infrastructure
Related to project infrastructure
type: imperfection
Perceived defect in any part of project
Describe the problem
Originally from #2543 (comment):
I recognize that the team is small and that code reviews do not receive enough attention from maintainers. However, this CI error effectively blocks collaboration on the project.
To reproduce
Open a PR from a fork. The PR must include code changes. For example, changing markdown files won't trigger an electron build. See #2543 as an example.
Expected behavior
The Windows signing does not run on PRs opened from forks.
Or
The Windows signing works.
Arduino IDE version
3ccc864
Operating system
Windows
Operating system version
It's a CI
Additional context
Breaking change: 2e78e96.
CIs are smart to mask secrets, but I would probably remove the password printing to the console when not all envs are truthy.
arduino-ide/electron-app/scripts/windowsCustomSign.js
Line 26 in 3ccc864
There is a typo in the console log.
Issue checklist
The text was updated successfully, but these errors were encountered: