Skip to content

Commit 0a33cec

Browse files
committed
Move definition of package filename to dedicated step in release workflow
The package filename is referenced in multiple places in the release workflow. In order to avoid code duplication, it is defined once as an environment variable, then that variable referenced in each of the instances where the filename is needed. Previously, this was done by first defining and referencing a shell environment variable at the point of the first usage, then defining a workflow environment variable and referencing that in the second usage. The maintainability and readability of the workflow is improved by using a single workflow environment variable, defined in the step dedicated to defining such variables, then referencing it consistently in all usages.
1 parent 705c206 commit 0a33cec

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

.github/workflows/release-go-task.yml

+3-4
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,8 @@ jobs:
8888
run: |
8989
# See: https://docs.github.com/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-an-environment-variable
9090
echo "BUILD_FOLDER=${{ env.PROJECT_NAME }}_osx_${{ matrix.build.folder-suffix }}" >> "$GITHUB_ENV"
91+
TAG="${GITHUB_REF/refs\/tags\//}"
92+
echo "PACKAGE_FILENAME=${{ env.PROJECT_NAME }}_${TAG}_${{ matrix.build.package-suffix }}" >> $GITHUB_ENV
9193
9294
- name: Checkout repository
9395
uses: actions/checkout@v4
@@ -162,12 +164,9 @@ jobs:
162164
# GitHub's upload/download-artifact actions don't preserve file permissions,
163165
# so we need to add execution permission back until the action is made to do this.
164166
chmod +x "${{ env.BUILD_FOLDER }}/${{ env.PROJECT_NAME }}"
165-
TAG="${GITHUB_REF/refs\/tags\//}"
166-
PACKAGE_FILENAME="${{ env.PROJECT_NAME }}_${TAG}_${{ matrix.build.package-suffix }}"
167-
tar -czvf "$PACKAGE_FILENAME" \
167+
tar -czvf "${{ env.PACKAGE_FILENAME }}" \
168168
-C "${{ env.BUILD_FOLDER }}/" "${{ env.PROJECT_NAME }}" \
169169
-C ../../ LICENSE.txt
170-
echo "PACKAGE_FILENAME=$PACKAGE_FILENAME" >> $GITHUB_ENV
171170
172171
- name: Upload artifact
173172
uses: actions/upload-artifact@v3

0 commit comments

Comments
 (0)