Skip to content
This repository was archived by the owner on Oct 19, 2024. It is now read-only.
This repository was archived by the owner on Oct 19, 2024. It is now read-only.

Dumping App Conditions can contain sensitive information #390

@sidewinder12s

Description

@sidewinder12s

Summary

One of our apps went into a degraded state and then dumped a ComparisonError and the RPC message of the error which contained sensitive information/credentials. It seems like a lot of conditions could dump data out of the condition output.

Diagnostics

It appears to be this section of the templates.

          {{range $index, $c := .app.status.conditions}}
          {{if not $index}},{{end}}
          {{if $index}},{{end}}
          {
            "title": "{{$c.type}}",
            "value": "See App",
            "short": true
          }
          {{end}}

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions