-
Notifications
You must be signed in to change notification settings - Fork 339
Switch to audited and fast version of sha3/keccak #673
Copy link
Copy link
Open
Labels
low effortThere is not much implementation work to be done. The task is very easy or tiny.There is not much implementation work to be done. The task is very easy or tiny.low impactChanges are not very noticeable or potential benefits are limited.Changes are not very noticeable or potential benefits are limited.nice to haveWe don’t see a good reason not to have it but won’t go out of our way to implement it.We don’t see a good reason not to have it but won’t go out of our way to implement it.
Description
Metadata
Metadata
Assignees
Labels
low effortThere is not much implementation work to be done. The task is very easy or tiny.There is not much implementation work to be done. The task is very easy or tiny.low impactChanges are not very noticeable or potential benefits are limited.Changes are not very noticeable or potential benefits are limited.nice to haveWe don’t see a good reason not to have it but won’t go out of our way to implement it.We don’t see a good reason not to have it but won’t go out of our way to implement it.
You're using
js-sha3, while a better package would be https://github.com/paulmillr/noble-hashes which was audited and is utilized in https://github.com/ethereum/js-ethereum-cryptography.