Various performance improvements

Author: ClausHolbechArista

Diff for: python-avd/pyavd/_eos_cli_config_gen/schema/__init__.py

@@ -59,7 +59,7 @@ def render(self) -> dict:
         If the value is not cached, it will be resolved by the attribute function first.
         Empty values are removed from the returned data.
         """
-        return {key: getattr(self, key) for key in self.keys() if getattr(self, key) is not None}
+        return {key: value for key in self.keys() if (value := getattr(self, key)) is not None}
 
     def clear_cache(self) -> None:
         for key in self.keys() + self.internal_keys():

Diff for: python-avd/pyavd/_eos_designs/avdfacts.py

@@ -90,7 +90,7 @@ def _local_endpoint_vlans_and_trunk_groups(self: EosDesignsFactsProtocol) -> tup
         for connected_endpoints_key in self.inputs._dynamic_keys.connected_endpoints:
             for connected_endpoint in connected_endpoints_key.value:
                 for index, adapter in enumerate(connected_endpoint.adapters):
-                    adapter._context = f"{connected_endpoints_key.key}[name={connected_endpoint.name}].adapters[{index}]"
+                    adapter._internal_data.context = f"{connected_endpoints_key.key}[name={connected_endpoint.name}].adapters[{index}]"
                     adapter_settings = self.shared_utils.get_merged_adapter_settings(adapter)
                     if self.shared_utils.hostname not in adapter_settings.switches:
                         # This switch is not connected to this endpoint. Skipping.
@@ -114,7 +114,7 @@ def _local_endpoint_vlans_and_trunk_groups(self: EosDesignsFactsProtocol) -> tup
                     # Skip entry if no match
                     continue
 
-                network_port_item._context = f"network_ports[{index}]"
+                network_port_item._internal_data.context = f"network_ports[{index}]"
                 adapter_settings = self.shared_utils.get_merged_adapter_settings(network_port_item)
                 adapter_vlans, adapter_trunk_groups = self._parse_adapter_settings(adapter_settings)
                 vlans.update(adapter_vlans)

Diff for: python-avd/pyavd/_eos_designs/eos_designs_facts/vlans.py

@@ -33,6 +33,6 @@ def wan_path_groups(self: EosDesignsFactsProtocol) -> list | None:
 
         wan_path_groups = self.shared_utils.wan_local_path_groups._as_list()
         for wan_path_group in wan_path_groups:
-            wan_path_group["_interfaces"] = self.shared_utils.wan_local_path_groups[wan_path_group["name"]]._interfaces
+            wan_path_group["_interfaces"] = self.shared_utils.wan_local_path_groups[wan_path_group["name"]]._internal_data.interfaces
 
         return wan_path_groups