Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite recursion when no singleton controlling window available #42

Open
KyleMaas opened this issue Mar 24, 2021 · 1 comment
Open

Infinite recursion when no singleton controlling window available #42

KyleMaas opened this issue Mar 24, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@KyleMaas
Copy link
Collaborator

This is a new one:

bundle-ui.js:118422 Uncaught RangeError: Maximum call stack size exceeded
    at Object.module.exports.getSSB (bundle-ui.js:118395)
    at Object.module.exports.getSSB (bundle-ui.js:118422)
    at Object.module.exports.getSSB (bundle-ui.js:118422)
    at Object.module.exports.getSSB (bundle-ui.js:118422)
    at Object.module.exports.getSSB (bundle-ui.js:118422)
    at Object.module.exports.getSSB (bundle-ui.js:118422)
    at Object.module.exports.getSSB (bundle-ui.js:118422)
    at Object.module.exports.getSSB (bundle-ui.js:118422)
    at Object.module.exports.getSSB (bundle-ui.js:118422)
    at Object.module.exports.getSSB (bundle-ui.js:118422)

Evidently it stems from ssb-singleton's getSSB() calling the getSSB() of another window which turns out to be itself, causing infinite recursion. So we need to make sure we're not calling getSSB() of a window in the "other windows" list which is actually our own window.
@KyleMaas KyleMaas added the bug Something isn't working label Mar 24, 2021
@KyleMaas
Copy link
Collaborator Author

Huh. Evidently this can only happen if no window is able to locate a controller. Which shouldn't happen. So this is actually due to a different bug.

@KyleMaas KyleMaas changed the title Maximum call stack size exceeded Infinite recursion when no singleton controlling window available Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KyleMaas