-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changelog v135 #1941
Comments
/* 0335: disable Firefox Home (Activity Stream) telemetry ***/
user_pref("browser.newtabpage.activity-stream.feeds.telemetry", false);
user_pref("browser.newtabpage.activity-stream.telemetry", false); Why weren't these telemetry-related prefs also moved with the others to section 8500? Also, regarding the new sanitize prefs, I assume you just updated it to the same values as before for the new prefs? |
You can't but you can add all your pref overrides and get rid of the legacy crap before then So likely steps
those 2 telemetry prefs not in |
Yes. On shutdown, AF has always sanitized everything except site settings and passwords. For manual sanitizing AF (at least since site exceptions were added in I think FF102 ) also excludes cookies and site data since that doesn't respect the site exception (and we wouldn't want users to go ctrl-shift-del and hit enter and lose all their logins) |
Ahh, I know. Because the |
Also, all you mac and linux RFP users ... all hail me for getting this over the line after 3 years or so ... and also give a wave (no hailing) to @PieroV for the patch Lines 732 to 734 in 3d76c74
edit: i know this is v135 but FF136 has been released .. so start hailing |
how am I supposed to put in any warning - I already added the info in the release notes? For the record - the migration code from Firefox should preserve what you set and/or override in the v2 settings (AFAICT). Even if it didn't and it read that the new pref is already set (and you said your overwrote it with your value) - it won't take affect until you close (for sanitize on close) or do it manually (when you clear site data, or clear history) I said you need to 1) add overrides to suit and 2 open the dialogs to make sure the migration happens and to check your values There is nothing more I could do (except have gotten this out before v136 and even that may not have helped some people) - the defaults in AF are to sanitize Not blaming you - but do you have a backup and if not why not? Session restore (open tabs) is not a backup and shouldn't be treated as one. |
I'm not sure, as this is not clear to me. I guess it's safer for me to keep the legacy crap and only update the user.js only after updating to Firefox 136 then? I see that you removed the legacy prefs in user.js v135. Do the new prefs already exist in 135 to make it safer for them to be removed before installing version 136? BTW, WDYM by "It pays to open each dialog to ensure the migration happens."? Which dialogs? |
This doesn't make sense to me. The migration updates using your v2 pref from FF128. Meanwhile the user js sets the v3 prefs for FF136+ as per your override. If the migration says, oh this is user modified lets not touch it (IDK if it does this), then the value would be as per your override. So arkenfox's default is not used, it literally can't be used, you overrode it. So blame the migration code or maybe your override is not correct. I did say to open the dialog and check edit: knew it
|
Hi, could you please clarify which dialogs you are referring here to? |
Line 626 in 3d76c74
Line 655 in 3d76c74
Line 667 in 3d76c74
|
user_pref("privacy.resistFingerprinting", true);
user_pref("privacy.resistFingerprinting.letterboxing", true);
user_pref("webgl.disabled", true);
user_pref("privacy.spoof_english", 2);
/* override recipe: enable session restore ***/
user_pref("browser.startup.page", 3); // 0102
// user_pref("browser.privatebrowsing.autostart", false); // 0110 required if you had it set as true
// user_pref("browser.sessionstore.privacy_level", 0); // 1003 optional to restore cookies/formdata
user_pref("privacy.clearOnShutdown.history", false); // 2811 FF127 or lower
user_pref("privacy.clearOnShutdown_v2.historyFormDataAndDownloads", false); // 2811 FF128+
// 2820 optional to match when you use settings>Cookies and Site Data>Clear Data
// user_pref("privacy.clearSiteData.historyFormDataAndDownloads", false); // FF128+
// 2830 optional to match when you use Ctrl-Shift-Del (settings>History>Custom Settings>Clear History)
// user_pref("privacy.cpd.history", false); // FF127 or lower
// user_pref("privacy.clearHistory.historyFormDataAndDownloads", false); // FF128+ this is shadows useroveride and an image of the parrot message.... can't figure out what to change to keep the browsing history between each restart... kinda miffed it nuked shadows tab list that they had setup... but not a super big deal just want a working way to keep the tabs open with history between reboots |
and figured it out: // heavy resist fingerprinting
user_pref("privacy.resistFingerprinting", true);
user_pref("privacy.resistFingerprinting.letterboxing", true);
user_pref("webgl.disabled", true);
user_pref("privacy.spoof_english", 2);
// keep tabs and history between reboots
user_pref("privacy.clearHistory.browsingHistoryAndDownloads", false);
user_pref("privacy.clearHistory.formdata", true);
user_pref("privacy.clearOnShutdown_v2.browsingHistoryAndDownloads", false);
user_pref("privacy.clearOnShutdown_v2.downloads", true);
user_pref("privacy.clearOnShutdown_v2.formdata", true);
user_pref("privacy.clearSiteData.browsingHistoryAndDownloads", false);
user_pref("privacy.clearSiteData.formdata", true); and it works again |
edit: for all readers who may be struggling to understand
it's really quite simple: to quote myself from the OP
so taking // the pref you've been using since FF128
user_pref("privacy.clearOnShutdown_v2.historyFormDataAndDownloads", true); // history (+ download history) and forms
// the prefs migrated to
user_pref("privacy.clearOnShutdown_v2.browsingHistoryAndDownloads", true); // history (+ download history)
user_pref("privacy.clearOnShutdown_v2.downloads", true);
user_pref("privacy.clearOnShutdown_v2.formdata", true); // forms and // the pref you've been using since FF128
user_pref("privacy.clearSiteData.historyFormDataAndDownloads", true); // history (+ download history) and forms
// the prefs migrated to
user_pref("privacy.clearSiteData.browsingHistoryAndDownloads", true); // history (+ download history)
user_pref("privacy.clearSiteData.formdata", true); // forms and
good :)
[1] IDK exactly why they have a
^ this refers to the old legacy code prior to FF128 in case anyone |
@Thorin-Oakenpants My question is whetever or not it is safe to migrate to user.js v135 before updating to Firefox v136. I belive the better solution would be to keep the legacy crap (old migration prefs) until v137 before safely removing them? |
if i were you I would do if before updating. And after you update, open each dialog and check what you have - and if it;s not right change it in the dialog. Then close and restart and check the dialogs are correct - and if they're not then change them in the dialog and edit the user.js and close and restart and check.... until you get it right (it's really not that complicated) I'm not 100% certain about having to open the dialogs to force the migration, but I had some weird things in mine but i didn't record the order in which i was looking at prefs in about:config or checking UI etc - but some things didn't add up as I thought they would - didn't take notes. Honestly I think the migration is not as straightforward as migrating your values (and I'm not going to check), for example. And the default are not the same across the three dialogs The point was you should open the dialogs anyway to check As to your question - I am 100% sure the legacy pre-FF128 prefs are not used/consulted, because that wouldn't be respecting the user's current choices when migrating and all hell would break loose with complaints |
@Thorin-Oakenpants For me two things are still not clear: (1) Why can't we keep all the legacy FF128 prefs together with the new non-V2 and V2 prefs? I believe keeping all of them until version 137 or so makes it safer to upgrade Arkenfox. I use Arkenfox's defaults in regards to clear on shutdown and so on, but I still don't think it's safe to migrate somehow. (2) Regarding migration, should someone with default values worry about it? I have the following values in my Firefox 135.0.1 (all are Arkenfox defaults; I do not have override for them): So, if I understand it correctly:
For me it's not clear if applying the prefs now in version 135 will be invalid because as I understand it the V2 prefs are only relevant in 136, so if I apply the v135 update now it would basically be the same as not having Arkenfox after applying the update. I don't wanna risk it, so commenting here to be sure. |
because the section explaining it was getting out of control and too fucking messy and the prefs are no longer used - by now in FF136 you should have done the migration in 128 |
I updated my user.js today and (as per usual) have these settings: user_pref("privacy.resistFingerprinting", true); I noticed that that doesn't do the trick anymore – did I correctly gather that this is an FF136 issue and has not yet been patched? I apologize, I am not that savy in terms of in-depth tech talk. |
The user.js is immaterial - the change for RFP comes in FF136, which you should be on by now
|
Thank you very much for the insight! Do you think they will ever "fix" this on their end? |
It is fixed - in FF136 |
Sorry to be bugging you with this, but it doesn't seem to be working anymore for me. For example when logging into Github and getting the "Please verify your device" mail, it shows the actual operating system, which before it never did. |
That's what the fix is - https://bugzilla.mozilla.org/show_bug.cgi?id=1840385#c4 Do not spoof the OS in HTTP User Agent the patch description is a little misleading. We do spoof by ensuring the string is the same per OS
Before
Now
|
@Thorin-Oakenpants One thing is still not clear to me: is it safe to use the new user.js in version 135.0.1 considering that it only includes the new v2 clearOnShutdown prefs and resets previous ones? As I understand it, the v2 prefs will only be used in version 136, so if I update my user.js now in version 135.0.1, the clearOnShutdown prefs will have no effect until version 136. |
FYI: https://bugzilla.mozilla.org/show_bug.cgi?id=1952564#c2 - the migration is messed up - CHECK YOUR DIALOGS |
Sorry, but that doesn't not clarify my question. The thing is that prefsCleaner will run when I update the user.js to version 135 while being on Firefox version 135. That will make the old clearonShutdown prefs inactive and then only set the v2 prefs. How would they be migrated if prefsCleaner removes them? |
that wasn't an answer to your question, which I have answered at least three times, along with instructions on the release notes. I cannot help you any more. it was so people can blame the migration code for their woes, despite the instructions (which not everyone will read, but there was nothing else I could do), not arkenfox |
For anyone out there, here's what I did: Updated to Firefox 136. Updated user.js to the latest version before starting Firefox 136 (and also used prefsCleaner). Then, I opened all those dialogs here: #1941 (comment) Afterwards, I manually checked I also checked the migration prefs, which are as follows for me (I hadn't opened the dialogs in the previous migration because I didn't even know about it): From my checks of the new entries regarding Hope this helps anyone out there. |
🟩 v133
FF134 release notes | for developers | security advisories
FF135 release notes | for developers | security advisories
CHANGELOG
There was nothing to add from 134 or 135
These changes all stem from 1888466 in 136 and sanitizing choices
*historyFormDataAndDownloads
pref migrates to the relevant prefs below2800
was getting messy and confusing⭐ 136 is here (don't ever wait for arkenfox before updating Firefox!) so my bad, sue me, I should have had this out before FF136 stable was released. Suggest y'all check/update your sanitizing overrides: make sure to open each dialog to ensure migration
v2.downloads
pref, it doesn't seem to be controlled by the UIcpd
toclearHistory
migration may have required you to open the clear history dialog: see comments in 9bba578NOTE: the STATs section excludes the new 8500 TELEMETRY section
ALL HAIL PANTS
The text was updated successfully, but these errors were encountered: