Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aroma Shooter response improvement #8

Open
Ekristoffe opened this issue Feb 20, 2021 · 1 comment
Open

Aroma Shooter response improvement #8

Ekristoffe opened this issue Feb 20, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@Ekristoffe
Copy link
Contributor

Ekristoffe commented Feb 20, 2021

Hello,
At the moment only the command "/as2/stop_all" return the serial number.
I think it could be a good idea to have the serial number returned by every command.
The command "/as2/diffuse" would return

{
    "serial":"ASN2A00001",
    "status":"done"
}

The command "/as2/firmware" would return

{
    "serial":"ASN2A00001",
    "current": "1.0.0",
    "latest": "1.0.1",
    "internet": "true"
}

Also for the Post command i think a return like this would be helpful in case of bad body:

{
    "serial":"ASN2A00001",
    "status":"failed",
    "reason":"[the failure reason]"
}
@hanhdt hanhdt added the enhancement New feature or request label Feb 21, 2021
@hanhdt
Copy link
Contributor

hanhdt commented Feb 22, 2021

Hi @Ekristoffe,

Thanks for your suggestions.
I think it's a good ideas for returning device serial.

Because parsing and returning more data will impact to runtime memory, we need to balance to hardware memory limitation.
I will update you if there is any changes on the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants