Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: Edit Digital Object page is missing images #1915

Closed
anvit opened this issue Jan 31, 2025 · 0 comments · Fixed by #1916, #1928 or #1930
Closed

Problem: Edit Digital Object page is missing images #1915

anvit opened this issue Jan 31, 2025 · 0 comments · Fixed by #1916, #1928 or #1930
Assignees
@anvit
Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Milestone
2.9.0

Comments

@anvit
Copy link
Contributor

anvit commented Jan 31, 2025 •
edited
Loading

Current Behavior

Steps to reproduce the behavior

  1. Make sure you're using a BS5 theme.
  2. Go to a digital object and click More > Edit Digital Object
  3. Notice that the image at the top is missing. It appears for a second and then disappears when the page loads.
  4. Note that the image still shows in a BS2 theme.

Another bug on the same page that only presents itself when running PHP 8.x is that the reference and thumbnail images don't show and only generic icons can be seen.

Expected Behavior

The edit digital object page should display the digital object at the top in addition to the thumbnail and reference representations.
@anvit anvit added the Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. label Jan 31, 2025
@anvit anvit added this to the 2.9.0 milestone Jan 31, 2025
@anvit anvit self-assigned this Jan 31, 2025
anvit added a commit that referenced this issue Jan 31, 2025
@anvit
Fix DO images in the edit DO page (#1915)
64032cc 
Using a div with appropriate styling classes instead of a section for
the image in the edit DO page header since blank.js filters/removes any
sections that do not have content meant for sections.

Also updating the resource sent to the QubitAcl check to point to the
parents' object instead of the resources' object in the scenario when
that object is empty.
@anvit anvit linked a pull request Jan 31, 2025 that will close this issue
Fix DO images in the edit DO page (#1915) #1916
Merged
anvit added a commit that referenced this issue Feb 4, 2025
@anvit
Fix DO images in the edit DO page (#1915)
bbccdc5 
Using a div with appropriate styling classes instead of a section for
the image in the edit DO page header since blank.js filters/removes any
sections that do not have content meant for sections.

Also updating the resource sent to the QubitAcl check to point to the
parents' object instead of the resources' object in the scenario when
that object is empty.
anvit added a commit that referenced this issue Feb 4, 2025
@anvit
Fix DO images in the edit DO page (#1915)
2378d48 
Using a div with appropriate styling classes instead of a section for
the image in the edit DO page header since blank.js filters/removes any
sections that do not have content meant for sections.

Also updating the resource sent to the QubitAcl check to point to the
parents' object instead of the resources' object in the scenario when
that object is empty.
anvit added a commit that referenced this issue Feb 4, 2025
@anvit
Fix DO images in the edit DO page (#1915)
83b6a5a 
Using a div with appropriate styling classes instead of a section for
the image in the edit DO page header since blank.js filters/removes any
sections that do not have content meant for sections.

Also updating the resource sent to the QubitAcl check to point to the
parents' object instead of the resources' object in the scenario when
that object is empty.
anvit added a commit that referenced this issue Feb 13, 2025
@anvit
Fix object for Acl check in showComponent (#1915)
2524865 
Update showComponent to always use parent object for Acl check.
@anvit anvit reopened this Feb 13, 2025
@anvit anvit linked a pull request Feb 13, 2025 that will close this issue
Fix object for Acl check in showComponent (#1915) #1928
Merged
anvit added a commit that referenced this issue Feb 13, 2025
@anvit
Fix object for Acl check in showComponent (#1915)
e1c4c8a 
Update showComponent to always use parent object for Acl check.
anvit added a commit that referenced this issue Feb 14, 2025
@anvit
Fix object for Acl check in showComponent (#1915)
fc387cc 
Update showComponent to always use parent object for Acl check.
anvit added a commit that referenced this issue Feb 14, 2025
@anvit
Revert fix for showComponent and fix typo (#1915)
628df8c 
Revert the change to showComponent that was changing the showComponent
to always use the parent object for reference and thumbnail since this
broke description page with attatched digital objects. Updating the last
fix to showComponent with the typo fixed resolves this bug since it uses
the parent object only when it is not null.
@anvit anvit reopened this Feb 14, 2025
@anvit anvit linked a pull request Feb 14, 2025 that will close this issue
Revert fix for showComponent and fix typo (#1915) #1930
Merged
anvit added a commit that referenced this issue Feb 19, 2025
@anvit
Fix resource sent from editRepresentation (#1915)
d589188 
Fix editRepresentation to send $resource instead of $representation as
the resource to showComponent
anvit added a commit that referenced this issue Feb 20, 2025
@anvit
Revert fix for showComponent and fix typo (#1915)
d076bf5 
Revert the change to showComponent that was changing the showComponent
to always use the parent object for reference and thumbnail since this
broke description page with attatched digital objects. Updating the last
fix to showComponent with the typo fixed resolves this bug since it uses
the parent object only when it is not null.
anvit added a commit that referenced this issue Feb 20, 2025
@anvit
Fix resource sent from editRepresentation (#1915)
3835404 
Fix editRepresentation to send $resource instead of $representation as
the resource to showComponent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anvit anvit

Labels
Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Milestone
2.9.0
1 participant
@anvit