Skip to content

Commit ae0d86c

Browse files
committed
Ignore test failures from www.dgii.gov.do
There was a change in the SOAP service and there is a new URL. However, the API has changed and seems to require authentication. We ignore test failures for now but unless a solution is found the DGII validation will be removed. See: #462 See: #461
1 parent dcd7fa6 commit ae0d86c

File tree

2 files changed

+24
-0
lines changed

2 files changed

+24
-0
lines changed

tests/test_do_cedula.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,14 @@ class TestDGII(unittest.TestCase):
3636
"""Test the web services provided by the the Dirección General de
3737
Impuestos Internos (DGII), the Dominican Republic tax department."""
3838

39+
# Theses tests currently fail because the SOAP service at
40+
# https://www.dgii.gov.do/wsMovilDGII/WSMovilDGII.asmx?WSDL
41+
# is no longer available. There is a new one at
42+
# https://www.dgii.gov.do/ventanillaunica/ventanillaunica.asmx?WSDL
43+
# but it has a different API and seems to require authentication.
44+
# See https://github.com/arthurdejong/python-stdnum/pull/462
45+
# and https://github.com/arthurdejong/python-stdnum/issues/461
46+
@unittest.expectedFailure
3947
def test_check_dgii(self):
4048
"""Test stdnum.do.cedula.check_dgii()"""
4149
# Test a normal valid number

tests/test_do_rnc.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,14 @@ class TestDGII(unittest.TestCase):
3636
"""Test the web services provided by the the Dirección General de
3737
Impuestos Internos (DGII), the Dominican Republic tax department."""
3838

39+
# Theses tests currently fail because the SOAP service at
40+
# https://www.dgii.gov.do/wsMovilDGII/WSMovilDGII.asmx?WSDL
41+
# is no longer available. There is a new one at
42+
# https://www.dgii.gov.do/ventanillaunica/ventanillaunica.asmx?WSDL
43+
# but it has a different API and seems to require authentication.
44+
# See https://github.com/arthurdejong/python-stdnum/pull/462
45+
# and https://github.com/arthurdejong/python-stdnum/issues/461
46+
@unittest.expectedFailure
3947
def test_check_dgii(self):
4048
"""Test stdnum.do.rnc.check_dgii()"""
4149
# Test a normal valid number
@@ -58,6 +66,14 @@ def test_check_dgii(self):
5866
result = rnc.check_dgii('132070801')
5967
self.assertEqual(result['rnc'], '132070801')
6068

69+
# Theses tests currently fail because the SOAP service at
70+
# https://www.dgii.gov.do/wsMovilDGII/WSMovilDGII.asmx?WSDL
71+
# is no longer available. There is a new one at
72+
# https://www.dgii.gov.do/ventanillaunica/ventanillaunica.asmx?WSDL
73+
# but it has a different API and seems to require authentication.
74+
# See https://github.com/arthurdejong/python-stdnum/pull/462
75+
# and https://github.com/arthurdejong/python-stdnum/issues/461
76+
@unittest.expectedFailure
6177
def test_search_dgii(self):
6278
"""Test stdnum.do.rnc.search_dgii()"""
6379
# Search for some existing companies

0 commit comments

Comments
 (0)