Skip to content

Commit c986a92

Browse files
ggerganovarthw
authored andcommitted
contrib : refresh (ggml-org#10593)
* contrib : refresh * contrib : expand [no ci] * contrib : expand test-backend-ops instructions * contrib : add CODEOWNERS * prs : update template to not have checkbox [no ci]
1 parent 3d85b01 commit c986a92

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

.github/pull_request_template.md

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1 @@
1-
2-
3-
- [x] I have read the [contributing guidelines](https://github.com/ggerganov/llama.cpp/blob/master/CONTRIBUTING.md)
4-
- Self-reported review complexity:
5-
- [ ] Low
6-
- [ ] Medium
7-
- [ ] High
1+
*Make sure to read the [contributing guidelines](https://github.com/ggerganov/llama.cpp/blob/master/CONTRIBUTING.md) before submitting a PR*

CODEOWNERS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# collaborators can optionally add themselves here to indicate their availability for reviewing related PRs
2+
3+
ci/ @ggerganov

CONTRIBUTING.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
# Pull requests (for contributors)
22

33
- Test your changes:
4-
- Using the commands in the [`tests`](tests) folder. For instance, running the `./tests/test-backend-ops` command tests different backend implementations of the `ggml` library
54
- Execute [the full CI locally on your machine](ci/README.md) before publishing
6-
- Optionally rate the complexity of your PR (i.e. `Review Complexity : Low`, `Review Complexity : Medium`, `Review Complexity : High`). This makes it easier for maintainers to triage the PRs
5+
- Verify that the perplexity and the performance are not affected negatively by your changes (use `llama-perplexity` and `llama-bench`)
6+
- If you modified the `ggml` source, run the `test-backend-ops` tool to check whether different backend implementations of the `ggml` operators produce consistent results (this requires access to at least two different `ggml` backends)
7+
- If you modified a `ggml` operator or added a new one, add the corresponding test cases to `test-backend-ops`
78
- Consider allowing write access to your branch for faster reviews, as reviewers can push commits directly
89
- If your PR becomes stale, don't hesitate to ping the maintainers in the comments
910

@@ -12,6 +13,7 @@
1213
- Squash-merge PRs
1314
- Use the following format for the squashed commit title: `<module> : <commit title> (#<issue_number>)`. For example: `utils : fix typo in utils.py (#1234)`
1415
- Optionally pick a `<module>` from here: https://github.com/ggerganov/llama.cpp/wiki/Modules
16+
- Consider adding yourself to [CODEOWNERS](CODEOWNERS)
1517

1618
# Coding guidelines
1719

0 commit comments

Comments
 (0)