Skip to content

Commit 1855d28

Browse files
committed
Fix issue introduced in admin
Fixed an incorrect if statement in the admin. Bumped to 0.13.0
1 parent 55748fc commit 1855d28

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
44

55
[project]
66
name = "django-approval"
7-
version = "0.12.0"
7+
version = "0.13.0"
88
authors = [
99
{ name="Steve Kossouho", email="[email protected]" },
1010
]

src/approval/admin/monitored.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,15 @@ def get_object(self, request, object_id, from_field: str = None) -> MonitoredMod
2121
obj: MonitoredModel = super().get_object(request, object_id)
2222
if isinstance(obj, MonitoredModel):
2323
# Only display approval warning if the object has not been approved.
24-
if hasattr(obj, "approval") and obj.approval and not obj.approval.approved:
24+
if hasattr(obj, "approval") and obj.approval:
2525
obj.approval._update_source(default=False, save=False)
2626
obj.request = request
27-
self.message_user(
28-
request,
29-
pgettext_lazy("approval", "This form is showing changes currently pending."),
30-
level=messages.WARNING,
31-
)
27+
if obj.approval.approved != True:
28+
self.message_user(
29+
request,
30+
pgettext_lazy("approval", "This form is showing changes currently pending."),
31+
level=messages.WARNING,
32+
)
3233
else:
3334
raise ImproperlyConfigured(f"No approval model was declared for this model.")
3435
return obj

0 commit comments

Comments
 (0)