Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for attribute slicing in benchmarking module #160

Open
andkay opened this issue Dec 7, 2021 · 0 comments
Open

Support for attribute slicing in benchmarking module #160

andkay opened this issue Dec 7, 2021 · 0 comments
Assignees

Comments

@andkay
Copy link
Contributor

andkay commented Dec 7, 2021

In previous iterations, we required project-specific implementations of benchmark tools. The more generalised approached is better but is problematic when benchmark data is logically related to a subset of the entire population.

The particular example that is causing a headache at the moment is trip_mode_shares_comparison. Typically, the benchmark data would come from census journey to work data or similar. The comparison requires looking only at modeshares for the "general population" -- i.e. excluding goods vehicles and agents that are external to the study area (which we include sometimes to get the full demand on the local network, but don't actually care about otherwise).

There are some workarounds, including restructuring the benchmark data to be grouped by subpopulations (with arbitrary values) or by using a destination_activity_filter to exclude particular activities (e.g. delivery). But these are cumbersome and potentially limit our ability to score simulations on how close they match benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants