Skip to content

Commit

Permalink
feat(submit:github): disable Github forge detection by default
Browse files Browse the repository at this point in the history
Prerequisite for a new release so that we don't break everyone who is submitting to Github.
  • Loading branch information
arxanas committed Apr 28, 2024
1 parent 0e171fb commit 33d60b9
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions git-branchless-submit/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -555,9 +555,14 @@ fn select_forge<'a>(
};

// Check Github:
let forge_kind = match forge_kind {
Some(forge_kind) => Some(forge_kind),
None => github_push_remote(repo)?.map(|_| ForgeKind::Github),
let is_github_forge_reliable_enough_for_opt_out_usage = false; // as of 2024-04-06 it's too buggy; see https://github.com/arxanas/git-branchless/discussions/1259
let forge_kind = match (
forge_kind,
is_github_forge_reliable_enough_for_opt_out_usage,
) {
(Some(forge_kind), _) => Some(forge_kind),
(None, true) => github_push_remote(repo)?.map(|_| ForgeKind::Github),
(None, false) => None,
};

// Default:
Expand Down

0 comments on commit 33d60b9

Please sign in to comment.