feat: Meta Icons and Icon Shown conditions now use pure event-driven updates.

Author: ascott18

CHANGELOG.md

@@ -1,5 +1,7 @@
 ## v11.2.5
+* Meta Icons and Icon Shown conditions now use pure event-driven updates. This is made possible by dynamic, dependency-aware ordering of icon update checks. If you have circular dependencies between icons, you may find that some updates may be delayed by at least one update interval. 
 * While Condition Set Passing and On Condition Set Passing triggers for notifications no longer evaluate while their icon's group is not shown/active. This now matches the behavior of all other notification triggers.
+* Unit Conditions no longer evaluate while the icon that requested them is not shown/active.
 
 ## v11.2.4
 * Fix Spells.lua:27: attempt to index field "SpellBookSpellBank" (a nil value)

Components/Core/Conditions/Categories/Misc.lua

@@ -59,25 +59,21 @@ ConditionCategory:RegisterCondition(1,	 "ICON", {
 	unit = false,
 	icon = "Interface\\Icons\\INV_Misc_PocketWatch_01",
 	tcoords = CNDT.COMMON.standardtcoords,
-	Env = {
-		IsIconShown = function(icon)
-			if not icon or not icon.attributes.shown then return false end
-			icon:Update()
-			return icon.attributes.realAlpha > 0
-		end
-	},
 	funcstr = function(c, icon)
 		TMW:QueueValidityCheck(icon, c.Icon, L["VALIDITY_CONDITION_DESC"])
 
-		return "BOOLCHECK(IsIconShown(c.Icon))"
+		return "BOOLCHECK(c.Icon and c.Icon.attributes.shown and c.Icon.attributes.realAlpha > 0)"
 	end,
-	--[[events = function(ConditionObject, c)
+	events = function(ConditionObject, c)
 		local event = TMW.Classes.IconDataProcessor.ProcessorsByName.REALALPHA.changedEvent
 		ConditionObject:RequestEvent(event)
+		local event2 = TMW.Classes.IconDataProcessor.ProcessorsByName.SHOWN.changedEvent
+		ConditionObject:RequestEvent(event2)
+
 		ConditionObject:SetNumEventArgs(1)
 		return
-			"event == '" .. event .. "' and arg1:GetGUID() == " .. format("%q", c.Icon)
-	end,]]
+			"(event == '" .. event .. "' or event == '" .. event2 .. "') and arg1:GetGUID() == " .. format("%q", c.Icon)
+	end,
 })
 
 local function RegisterShownHiddenTimerCallback()
@@ -163,6 +159,19 @@ TMW:RegisterCallback("TMW_EXPORT_SETTINGS_REQUESTED", function(event, strings, t
 	end
 end)
 
+-- Collect icon dependencies from conditions
+TMW:RegisterCallback("TMW_COLLECT_ICON_DEPENDENCIES", function(event, icon, dependencies)
+	if icon and icon.Conditions then
+		for n, conditionSettings in TMW:InNLengthTable(icon.Conditions) do
+			local GUID = conditionSettings.Icon
+			if GUID and GUID ~= "" then
+				tinsert(dependencies, GUID)
+			end
+		end
+	end
+end)
+
+
 
 ConditionCategory:RegisterCondition(3,	 "MOUSEOVER", {
 	text = L["MOUSEOVERCONDITION"],

Components/Core/Icon.lua

@@ -179,8 +179,116 @@ function Icon.ScriptSort(iconA, iconB)
 	end
 	return gA < gB
 end
-Icon:UpdateTable_SetAutoSort(Icon.ScriptSort)
-TMW:RegisterCallback("TMW_GLOBAL_UPDATE_POST", Icon, "UpdateTable_PerformAutoSort")
+
+-- Dependency-aware sorting function
+local function SortIconUpdateTable(icons)
+	-- First, collect all dependencies for all icons
+	local iconDependencies = {}
+	local iconsByGUID = {}
+	local iconsInTable = {}
+	
+	-- Build lookup tables
+	for i = 1, #icons do
+		local icon = icons[i]
+		iconsInTable[icon] = i
+		local iconGUID = icon:GetGUID()
+		if iconGUID then
+			iconsByGUID[iconGUID] = icon
+		end
+	end
+	
+	-- Collect dependencies for each icon
+	for i = 1, #icons do
+		local icon = icons[i]
+		local dependencies = {}
+		
+		-- Fire the dependency collection event
+		TMW:Fire("TMW_COLLECT_ICON_DEPENDENCIES", icon, dependencies)
+		
+		-- Filter dependencies to only include icons that are actually in the update table
+		local filteredDeps = {}
+		for _, depGUID in ipairs(dependencies) do
+			local depIcon = TMW.GUIDToOwner[depGUID]
+			if depIcon and iconsInTable[depIcon] then
+				tinsert(filteredDeps, depIcon)
+			end
+		end
+		
+		iconDependencies[icon] = filteredDeps
+	end
+	
+	-- Perform topological sort with fallback to original sort for cycles
+	local sorted = {}
+	local visiting = {}
+	local visited = {}
+	local hasCycle = {}
+	
+	local function visit(icon)
+		if visiting[icon] then
+			-- Cycle detected
+			hasCycle[icon] = true
+			return
+		end
+		if visited[icon] then
+			return
+		end
+		
+		visiting[icon] = true
+		
+		-- Visit all dependencies first
+		local deps = iconDependencies[icon] or {}
+		for _, depIcon in ipairs(deps) do
+			if not hasCycle[depIcon] then
+				visit(depIcon)
+			end
+		end
+		
+		visiting[icon] = nil
+		visited[icon] = true
+		tinsert(sorted, icon)
+	end
+	
+	-- Sort icons by the original criteria first to maintain deterministic order
+	local iconsCopy = {}
+	for i = 1, #icons do
+		iconsCopy[i] = icons[i]
+	end
+	sort(iconsCopy, Icon.ScriptSort)
+	
+	-- Visit all icons in the original sort order
+	for _, icon in ipairs(iconsCopy) do
+		if not visited[icon] and not hasCycle[icon] then
+			visit(icon)
+		end
+	end
+	
+	-- Add any icons that were part of cycles at the end, in original sort order
+	for _, icon in ipairs(iconsCopy) do
+		if hasCycle[icon] and not visited[icon] then
+			tinsert(sorted, icon)
+			visited[icon] = true
+		end
+	end
+	
+	-- Copy the sorted result back to the original array
+	for i = 1, #sorted do
+		icons[i] = sorted[i]
+	end
+end
+
+-- Debounced sorting triggered by icon setup changes
+-- By triggering on icon setup instead of TMW_GLOBAL_UPDATE_POST,
+-- we can perform sorting after icons and groups are enabled/disabled with slash commands.
+local sortUpdateQueued = false
+TMW:RegisterCallback("TMW_ICON_SETUP_POST", function()
+	if not sortUpdateQueued then
+		sortUpdateQueued = true
+		C_Timer.After(0, function()
+			sortUpdateQueued = false
+			SortIconUpdateTable(TMW.IconsToUpdate)
+		end)
+	end
+end)
 
 -- [WRAPPER] (no documentation needed)
 Icon.SetScript_Blizz = Icon.SetScript
@@ -581,6 +689,14 @@ function Icon.SetUpdateMethod(icon, method)
 	end
 end
 
+--- Gets the update method that is being used by the icon.
+-- @name Icon:GetUpdateMethod
+-- @paramsig
+-- @return [string] The update method being used by the icon ("auto" or "manual")
+function Icon.GetUpdateMethod(icon)
+	return icon.Update_Method or "auto"
+end
+
 -- [INTERNAL] (no documentation needed)
 function Icon.ScheduleNextUpdate(icon)
 	local time = TMW.time

Components/Core/Utils.lua

@@ -87,6 +87,13 @@ Formatter{
 
 	D_SECONDS = Formatter:New(D_SECONDS),
 	S_SECONDS = Formatter:New(L["ANIM_SECONDS"]),
+	S_SECONDS_UPS = Formatter:New(function(value)
+		if value == 0 then
+			return L["UIPANEL_UPDATEINTERVAL_UPS"]:format(0.001, 1000)
+		else
+			return L["UIPANEL_UPDATEINTERVAL_UPS"]:format(value, ("%d"):format(1/value))
+		end
+	end),
 
 	PIXELS = Formatter:New(L["ANIM_PIXELS"]),