Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate parametrized events on different lines are not detected #113

Closed
stephanemagnenat opened this issue Aug 3, 2017 · 2 comments
Closed

Duplicate parametrized events on different lines are not detected #113

stephanemagnenat opened this issue Aug 3, 2017 · 2 comments
Assignees
@marvelous
Labels
bug reactive mode
Milestone
4

Comments

@stephanemagnenat
Copy link
Member

stephanemagnenat commented Aug 3, 2017 •
edited
Loading

If the same set of events with the same parametrization appear on two different lines, this error is not currently detected:
screen shot 2017-08-03 at 13 36 14

In this case, VPL1 shows a red line with linking the two faulty lines:
screen shot 2017-08-03 at 13 43 28
@marvelous
Copy link
Collaborator

By default, we'll compare the params value and leave open the possibility for the block to do more exhaustive checks.

@marvelous marvelous added this to the M4 milestone Aug 14, 2017
@marvelous marvelous self-assigned this Aug 16, 2017
@marvelous
Copy link
Collaborator

marvelous commented Nov 2, 2017 •
edited
Loading

As per #116, we should only detect the case where the events are the same (not every possibly overlapping case) and there are conflicting actions.

marvelous pushed a commit that referenced this issue Jan 22, 2018
@sampla
Transitions with the same events are allowed iif their actions do not…
3ac1f69 
… overlap. Fixes #113
mbonani pushed a commit to mbonani/thymio-vpl2 that referenced this issue Feb 27, 2018
@sampla
Transitions with the same events are allowed iif their actions do not…
626a237 
… overlap. Fixes aseba-community#113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marvelous marvelous

Labels
bug reactive mode
Projects
None yet
Milestone
4
Development

No branches or pull requests
2 participants
@stephanemagnenat @marvelous