chore: code cleanup in media downloader

Author: ashishb

src/wp2hugo/internal/hugogenerator/media_downloader.go

@@ -12,25 +12,34 @@ import (
 
 func writeFavicon(outputDirPath string, websiteURL string) error {
 	log.Debug().Msg("Fetching and writing favicon")
-	if err := createDirIfNotExist(path.Join(outputDirPath, "static")); err != nil {
-		return err
-	}
 	filePath := path.Join(outputDirPath, "static", "favicon.ico")
 	if !strings.HasPrefix(websiteURL, "http") {
 		websiteURL = "https://" + websiteURL
 	}
 	url1 := fmt.Sprintf("%s/favicon.ico", websiteURL)
-	resp, err := http.Get(url1)
+	return downloadFromURL(url1, filePath)
+}
+
+func downloadFromURL(srcURL string, destFilePath string) error {
+	log.Debug().
+		Str("srcURL", srcURL).
+		Str("destFilePath", destFilePath).
+		Msg("Downloading from URL")
+	if err := createDirIfNotExist(path.Dir(destFilePath)); err != nil {
+		return err
+	}
+
+	resp, err := http.Get(srcURL)
 	if err != nil {
-		return fmt.Errorf("error fetching favicon: %s", err)
+		return fmt.Errorf("error fetching %s: %s", srcURL, err)
 	}
 	defer resp.Body.Close()
 	if resp.StatusCode != http.StatusOK {
-		return fmt.Errorf("error fetching favicon: %s", resp.Status)
+		return fmt.Errorf("error fetching %s: %s", srcURL, resp.Status)
 	}
-	file, err := os.OpenFile(filePath, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644)
+	file, err := os.OpenFile(destFilePath, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644)
 	if err != nil {
-		return fmt.Errorf("error opening favicon file: %s", err)
+		return fmt.Errorf("error opening file %s: %s", file, err)
 	}
 	defer file.Close()
 	return resp.Write(file)