refactor endpoints to use protocol/hostname when no endpoints set

Author: darragh

lib/intercom.rb

@@ -48,12 +48,7 @@ def self.api_key=(api_key)
   def self.target_base_url
     raise ArgumentError, "You must set both Intercom.app_id and Intercom.api_key to use this client. See https://github.com/intercom/intercom-ruby for usage examples." if [@app_id, @api_key].any?(&:nil?)
     basic_auth_part = "#{@app_id}:#{@api_key}@"
-    if @endpoints.nil? || @endpoints.empty?
-      "#{protocol}://#{basic_auth_part}#{hostname}"
-    else
-      endpoint = @endpoints[0]
-      endpoint.gsub(/(https?:\/\/)(.*)/, "\\1#{basic_auth_part}\\2")
-    end
+    endpoints[0].gsub(/(https?:\/\/)(.*)/, "\\1#{basic_auth_part}\\2")
   end
 
   def self.send_request_to_path(request)
@@ -63,6 +58,7 @@ def self.send_request_to_path(request)
       @endpoints = @endpoints.rotate
       request.execute(target_base_url)
     end
+
   end
 
   def self.post(path, payload_hash)
@@ -111,6 +107,10 @@ def self.endpoints=(endpoints) #nodoc
     @endpoints = endpoints
   end
 
+  def self.endpoints
+    @endpoints || ["#{@protocol}://#{hostname}"]
+  end
+
   # Raised when the credentials you provide don't match a valid account on Intercom.
   # Check that you have set <b>Intercom.app_id=</b> and <b>Intercom.api_key=</b> correctly.
   class AuthenticationError < StandardError;

spec/unit/intercom_spec.rb

@@ -49,6 +49,12 @@
         Intercom.endpoints = ["http://example.com","https://localhost:7654"]
         Intercom.target_base_url.must_equal "http://abc123:[email protected]"
       end
+
+      it "has endpoints" do
+        Intercom.endpoints.must_equal ["https://api.intercom.io"]
+        Intercom.endpoints = ["http://example.com","https://localhost:7654"]
+        Intercom.endpoints.must_equal ["http://example.com","https://localhost:7654"]
+      end
     end
   end