Skip to content

AuthUserEnvVar and AuthPassEnvVar are used in different contexts #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dayflower opened this issue Sep 4, 2024 · 1 comment
Open

Comments

@dayflower
Copy link

AuthUserEnvVar and AuthPassEnvVar were originally introduced for delegating auth user and password to ssh process environment. (#6, 5f54a8f)

e.g.

$ git-http-backend -auth_user_env_var=AUTH_USERNAME -auth_pass_env_var=AUTH_PASSWORD

and when a user accesses with user:foo, password:bar, then

AUTH_USERNAME=foo AUTH_PASSWORD=bar git ...

However, #17 introduced Basic Auth mechanism and utilize AuthUserEnvVar and AuthPassEnvVar for accepting user name and password.

If an operator starts with:

$ git-http-backend -auth_user_env_var=foo -auth_pass_env_var=bar -require_auth

then, only the user whose name is 'foo' and whose password is 'bar' is accepted, that's fine.

But this setting also enables "delegating auth info" feature above, then from the perspective of the git process, following environments are passed.

foo=foo bar=bar git ...

It's quite meaningless.

How about making different parameter for these two contexts?

@navetacandra
Copy link

did #19 solve ur problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants